From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/jpeg: fix build failure when qt5base tries to use libjpeg
Date: Tue, 21 Feb 2023 21:04:10 +0100 [thread overview]
Message-ID: <20230221210410.61bd1054@windsurf> (raw)
In-Reply-To: <20230221183051.4011311-1-giulio.benetti@benettiengineering.com>
On Tue, 21 Feb 2023 19:30:51 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Qt5 fails to build with libjpeg since the API is different from
> libjpeg-turbo and libjpeg-turbo is pointed as the library Qt5 usually link
> against to[0]. So let's default jpeg variant to libjpeg-turbo if
> BR2_PACKAGE_QT5BASE_JPEG is selected.
>
> Fixes:
> still not failed
>
> [0]: https://doc.qt.io/qt-5/qtgui-index.html#licenses-and-attributions
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/jpeg/Config.in | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/jpeg/Config.in b/package/jpeg/Config.in
> index 371f89aa49..3a39a0dfb8 100644
> --- a/package/jpeg/Config.in
> +++ b/package/jpeg/Config.in
> @@ -16,7 +16,8 @@ if BR2_PACKAGE_JPEG
>
> choice
> prompt "jpeg variant"
> - default BR2_PACKAGE_JPEG_TURBO if BR2_PACKAGE_JPEG_SIMD_SUPPORT
> + default BR2_PACKAGE_JPEG_TURBO if BR2_PACKAGE_JPEG_SIMD_SUPPORT || \
> + BR2_PACKAGE_QT5BASE_JPEG
I don't think this will work, as it doesn't prevent from using classic
libjpeg with Qt5, it only changes the default. So a user can still
select Qt5 + classic libjpeg, and the autobuilder randomization will
also generate such configurations.
If really classic libjpeg are jpeg-turbo are no longer compatible, then
we probably need to drop the virtual package entirely... but it's going
to be a lot of work to handle both variants in all packages using
jpeg...
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-02-21 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 18:30 [Buildroot] [PATCH] package/jpeg: fix build failure when qt5base tries to use libjpeg Giulio Benetti
2023-02-21 20:04 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221210410.61bd1054@windsurf \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.