From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7FF3C636D6 for ; Wed, 22 Feb 2023 11:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229673AbjBVLtE (ORCPT ); Wed, 22 Feb 2023 06:49:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230291AbjBVLtE (ORCPT ); Wed, 22 Feb 2023 06:49:04 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C51132CEA for ; Wed, 22 Feb 2023 03:49:03 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1pUncL-0006kZ-TH; Wed, 22 Feb 2023 12:49:01 +0100 Date: Wed, 22 Feb 2023 12:49:01 +0100 From: Florian Westphal To: Florian Westphal Cc: Sriram Yagnaraman , netfilter-devel@vger.kernel.org, Pablo Neira Ayuso Subject: Re: [RFC nf-next PATCH] netfilter: nft: introduce broute chain type Message-ID: <20230222114901.GF12484@breakpoint.cc> References: <20230222110337.15951-1-sriram.yagnaraman@est.tech> <20230222113731.GE12484@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230222113731.GE12484@breakpoint.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Florian Westphal wrote: > The br_netfilter_broute flag is required, but I don't like a new chain > type for this, nor keeping the drop/accept override. > > I'd add a new "broute" expression that sets the flag in the skb cb > and sets NF_ACCEPT, useable in bridge family -- I think that this would > be much more readable. Or, even simpler, extend nft_meta_bridge.c and extend nft userspace to support: nft ... meta broute set 1 accept We also support nftrace this way, so there is precedence for it.