From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CFCAC61DA4 for ; Wed, 22 Feb 2023 17:24:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3FUjZlLVgAl+XGCoTpZ36bTE/kBG6ML6uUg6twcc+nM=; b=nO9kmnv+7nj072 n6MK34vx/mwaip0RvyunmvvODFyo4QiCv+xD+nrVf0D2BKw9HSZSVDEEQY4dl+vgXqbdBPfbMpi7S Ci1blZmvh3r9Kh6HPFRQdrt+LQKh+6f8FggaL2Pgyr4J/abKCjvU7FsJ9DFPaLdI6laXdSo2wQLHi UiZJhiWYnVldK3eYdE565bMbcevkc2A2wlzOkNberI5YwOyEf4CmZeeNtFDc7TEqZqMJ8+tHZA7dc 0ZBfKdx7b0U25djhH1od9z09tOaByE7TRL6jd9eRch+1/WflO6WUyVVRdTkcRHAlLDVWSHt4NWnuu U5l5g6n4O7Gl9yZhzxYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUsqX-00DCiW-Up; Wed, 22 Feb 2023 17:24:02 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUspy-00DCQY-5g for linux-arm-kernel@lists.infradead.org; Wed, 22 Feb 2023 17:23:27 +0000 Received: by mail-lj1-x234.google.com with SMTP id e24so2359139ljj.3 for ; Wed, 22 Feb 2023 09:23:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nSnsOpv8KS0rCS6ksY5VSkRcczl5vnYaXjWVVff7kGI=; b=DEqh460Bb4lDxi7itAAchy/jrIh1Oa/jWaYu4Nx7cgDY96x8jDagi1unEus9USivCe hnkt0DAxuUro+wf1TVDiaPwef0RpD0ZP0ZUI8XqdpEPHbmWx56WXNhJwjrTSTcFh9L81 l9UdDjbAjJrPEQiIYw4C5tm5ibZkYM/+w/O51saS4ht8gDwJkU4o9D3Z6RpPtAhUnaWp XsuVGK3z0vNMtxihXuJ7DqtCo0g3x7kxtzvmUU74ztWEhfW5e7JLrAaE4tOs8EIf9lqf gOyOJeMDeRctrIJkNNsQLdgto+hJ4uQKSybCQG8NcK8wJBT3zd7HMfpr/tJ62VAC4HpK zZPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nSnsOpv8KS0rCS6ksY5VSkRcczl5vnYaXjWVVff7kGI=; b=Z028hIt7V0X8nZl06hDlIKl2afao7ZmnAW+OGOff7QzRcgW9zPmBvu/1VMXjwalglB mi8/7NNugbrj+pPZak/8fkLRxIiZVxm83nxC4V00238tKXc1zTXZAM9/1w8I7O/am5NS 2CoC7pDduHp6Xzem7X8SuzdtPEA7rXFMv3zWqnMwr58InsvM1MbzXkfDahvkMr7LBzTB Ln4r5G7FtpA6ZJdorWhq7B5CEcPNerWNP/DxSO9uvw8SRqe0dt63w0vGkZ5eOO0uqMvo TkSbpN8wKo25p3XQaxDDU/sYbeHdR9VMJFfteC+jPII3yvBoj7fnG0gooMblyNdF105x Zt+Q== X-Gm-Message-State: AO0yUKXN63/++v2zF4M+ZwRloebPeN9RqHHkQaCVzSatUVrMk45J6ccy X/JKepB3uKYXPrE+jNmfKuw= X-Google-Smtp-Source: AK7set8ci3FrIvgl9vUPXevbFYj2J3UGpD1jWl8kUSJoUcZ0ZOiGOLUbvHQ4ZGdGUqeYXnal0wky2g== X-Received: by 2002:a05:651c:50f:b0:293:4fff:422e with SMTP id o15-20020a05651c050f00b002934fff422emr4780096ljp.16.1677086602368; Wed, 22 Feb 2023 09:23:22 -0800 (PST) Received: from localhost.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id p2-20020a2e93c2000000b0029477417d80sm721513ljh.85.2023.02.22.09.23.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 09:23:21 -0800 (PST) From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Miquel Raynal , Michael Walle , gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, u-boot@lists.denx.de, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Subject: [PATCH 4/4] nvmem: u-boot-env: post-process "ethaddr" env variable Date: Wed, 22 Feb 2023 18:22:45 +0100 Message-Id: <20230222172245.6313-5-zajec5@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230222172245.6313-1-zajec5@gmail.com> References: <20230222172245.6313-1-zajec5@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230222_092326_242240_D8F1A2F4 X-CRM114-Status: GOOD ( 15.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RnJvbTogUmFmYcWCIE1pxYJlY2tpIDxyYWZhbEBtaWxlY2tpLnBsPgoKVS1Cb290IGVudmlyb25t ZW50IHZhcmlhYmxlcyBhcmUgc3RvcmVkIGluIEFTQ0lJIGZvcm1hdCBzbyAiZXRoYWRkciIKcmVx dWlyZXMgcGFyc2luZyBpbnRvIGJpbmFyeSB0byBtYWtlIGl0IHdvcmsgd2l0aCBFdGhlcm5ldCBp bnRlcmZhY2VzLgoKVGhpcyBpbmNsdWRlcyBzdXBwb3J0IGZvciBpbmRleGVzIHRvIHN1cHBvcnQg I252bWVtLWNlbGwtY2VsbHMgPSA8MT4uCgpTaWduZWQtb2ZmLWJ5OiBSYWZhxYIgTWnFgmVja2kg PHJhZmFsQG1pbGVja2kucGw+Ci0tLQogZHJpdmVycy9udm1lbS9LY29uZmlnICAgICAgfCAgMSAr CiBkcml2ZXJzL252bWVtL3UtYm9vdC1lbnYuYyB8IDI1ICsrKysrKysrKysrKysrKysrKysrKysr KysKIDIgZmlsZXMgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2RyaXZl cnMvbnZtZW0vS2NvbmZpZyBiL2RyaXZlcnMvbnZtZW0vS2NvbmZpZwppbmRleCAxODllYTg1YmQ2 N2QuLjcxMzIyZWE3Y2Y1MyAxMDA2NDQKLS0tIGEvZHJpdmVycy9udm1lbS9LY29uZmlnCisrKyBi L2RyaXZlcnMvbnZtZW0vS2NvbmZpZwpAQCAtMzQ2LDYgKzM0Niw3IEBAIGNvbmZpZyBOVk1FTV9V X0JPT1RfRU5WCiAJdHJpc3RhdGUgIlUtQm9vdCBlbnZpcm9ubWVudCB2YXJpYWJsZXMgc3VwcG9y dCIKIAlkZXBlbmRzIG9uIE9GICYmIE1URAogCXNlbGVjdCBDUkMzMgorCXNlbGVjdCBHRU5FUklD X05FVF9VVElMUwogCWhlbHAKIAkgIFUtQm9vdCBzdG9yZXMgaXRzIHNldHVwIGFzIGVudmlyb25t ZW50IHZhcmlhYmxlcy4gVGhpcyBkcml2ZXIgYWRkcwogCSAgc3VwcG9ydCBmb3IgdmVyaWZ5aW5n ICYgZXhwb3J0aW5nIHN1Y2ggZGF0YS4gSXQgYWxzbyBleHBvc2VzIHZhcmlhYmxlcwpkaWZmIC0t Z2l0IGEvZHJpdmVycy9udm1lbS91LWJvb3QtZW52LmMgYi9kcml2ZXJzL252bWVtL3UtYm9vdC1l bnYuYwppbmRleCAyOWIxZDg3YTNjNTEuLjFmNWQ4YWJhOThiZiAxMDA2NDQKLS0tIGEvZHJpdmVy cy9udm1lbS91LWJvb3QtZW52LmMKKysrIGIvZHJpdmVycy9udm1lbS91LWJvb3QtZW52LmMKQEAg LTQsNiArNCw4IEBACiAgKi8KIAogI2luY2x1ZGUgPGxpbnV4L2NyYzMyLmg+CisjaW5jbHVkZSA8 bGludXgvZXRoZXJkZXZpY2UuaD4KKyNpbmNsdWRlIDxsaW51eC9pZl9ldGhlci5oPgogI2luY2x1 ZGUgPGxpbnV4L21vZF9kZXZpY2V0YWJsZS5oPgogI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgog I2luY2x1ZGUgPGxpbnV4L210ZC9tdGQuaD4KQEAgLTcwLDYgKzcyLDI3IEBAIHN0YXRpYyBpbnQg dV9ib290X2Vudl9yZWFkKHZvaWQgKmNvbnRleHQsIHVuc2lnbmVkIGludCBvZmZzZXQsIHZvaWQg KnZhbCwKIAlyZXR1cm4gMDsKIH0KIAorc3RhdGljIGludCB1X2Jvb3RfZW52X3JlYWRfcG9zdF9w cm9jZXNzX2V0aGFkZHIodm9pZCAqY29udGV4dCwgY29uc3QgY2hhciAqaWQsIGludCBpbmRleCwK KwkJCQkJCXVuc2lnbmVkIGludCBvZmZzZXQsIHZvaWQgKipkYXRhLCBzaXplX3QgKmJ5dGVzKQor eworCXU4IG1hY1tFVEhfQUxFTl07CisKKwlpZiAoKmJ5dGVzICE9IDMgKiBFVEhfQUxFTiAtIDEp CisJCXJldHVybiAtRUlOVkFMOworCisJaWYgKCFtYWNfcHRvbigqZGF0YSwgbWFjKSkKKwkJcmV0 dXJuIC1FSU5WQUw7CisKKwlpZiAoaW5kZXgpCisJCWV0aF9hZGRyX2FkZChtYWMsIGluZGV4KTsK KworCS8qIFdlIG5lZWQgKnNtYWxsZXIqIGJ1ZmZlciBzbyBkb24ndCBib3RoZXIgdG8ga3JlYWxs b2MoKSAqLworCWV0aGVyX2FkZHJfY29weSgqZGF0YSwgbWFjKTsKKwkqYnl0ZXMgPSBFVEhfQUxF TjsKKworCXJldHVybiAwOworfQorCiBzdGF0aWMgaW50IHVfYm9vdF9lbnZfYWRkX2NlbGxzKHN0 cnVjdCB1X2Jvb3RfZW52ICpwcml2LCB1aW50OF90ICpidWYsCiAJCQkJc2l6ZV90IGRhdGFfb2Zm c2V0LCBzaXplX3QgZGF0YV9sZW4pCiB7CkBAIC0xMDEsNiArMTI0LDggQEAgc3RhdGljIGludCB1 X2Jvb3RfZW52X2FkZF9jZWxscyhzdHJ1Y3QgdV9ib290X2VudiAqcHJpdiwgdWludDhfdCAqYnVm LAogCQlwcml2LT5jZWxsc1tpZHhdLm9mZnNldCA9IGRhdGFfb2Zmc2V0ICsgdmFsdWUgLSBkYXRh OwogCQlwcml2LT5jZWxsc1tpZHhdLmJ5dGVzID0gc3RybGVuKHZhbHVlKTsKIAkJcHJpdi0+Y2Vs bHNbaWR4XS5ucCA9IG9mX2dldF9jaGlsZF9ieV9uYW1lKGRldi0+b2Zfbm9kZSwgcHJpdi0+Y2Vs bHNbaWR4XS5uYW1lKTsKKwkJaWYgKCFzdHJjbXAodmFyLCAiZXRoYWRkciIpKQorCQkJcHJpdi0+ Y2VsbHNbaWR4XS5yZWFkX3Bvc3RfcHJvY2VzcyA9IHVfYm9vdF9lbnZfcmVhZF9wb3N0X3Byb2Nl c3NfZXRoYWRkcjsKIAl9CiAKIAlpZiAoV0FSTl9PTihpZHggIT0gcHJpdi0+bmNlbGxzKSkKLS0g CjIuMzQuMQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17C7EC61DA4 for ; Wed, 22 Feb 2023 17:23:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232719AbjBVRX2 (ORCPT ); Wed, 22 Feb 2023 12:23:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230028AbjBVRXY (ORCPT ); Wed, 22 Feb 2023 12:23:24 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6982DBE4; Wed, 22 Feb 2023 09:23:22 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id a10so8674568ljq.1; Wed, 22 Feb 2023 09:23:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nSnsOpv8KS0rCS6ksY5VSkRcczl5vnYaXjWVVff7kGI=; b=DEqh460Bb4lDxi7itAAchy/jrIh1Oa/jWaYu4Nx7cgDY96x8jDagi1unEus9USivCe hnkt0DAxuUro+wf1TVDiaPwef0RpD0ZP0ZUI8XqdpEPHbmWx56WXNhJwjrTSTcFh9L81 l9UdDjbAjJrPEQiIYw4C5tm5ibZkYM/+w/O51saS4ht8gDwJkU4o9D3Z6RpPtAhUnaWp XsuVGK3z0vNMtxihXuJ7DqtCo0g3x7kxtzvmUU74ztWEhfW5e7JLrAaE4tOs8EIf9lqf gOyOJeMDeRctrIJkNNsQLdgto+hJ4uQKSybCQG8NcK8wJBT3zd7HMfpr/tJ62VAC4HpK zZPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nSnsOpv8KS0rCS6ksY5VSkRcczl5vnYaXjWVVff7kGI=; b=dBOt0yK5WPfqIv02p8jVK7Qu42kaSEoeb5RcYf2nC+6MTd3RHypxnKkiAo+sxSnY8Q rOywXb494Plba72Ig2B9t4oKv28zNkGBsMzbz/sGAeTn4+UOg3K/bR+KpFrEwwZX95wM K3M0oQauhPMyrCxEEUSJsZT1tpZ6FA3mQc6mOMOl95qp2ZtFR19cUw8eW3YMDwzuU90+ I9v8fLxr3tqyovh7cHQCBruFSYRGVEM1Yx7W7Ngzie8z2eXuDYkjsAdF2OhbzH4Vt9TJ J3aVezXPdS8sPblhBgo8h3AeQ5m2vfGr7ZS2TMssDUawG4n/RJqgNcGDGqLhCo8eXfpA pIEQ== X-Gm-Message-State: AO0yUKXcd0N9PETdXBpHwO+uHUvi5+j4qcEOTwUXitzQH0ZyCW8yYTz7 xejy2ODH1Tqz2rjRf1AqJCqeidfGQ5ZZSw== X-Google-Smtp-Source: AK7set8ci3FrIvgl9vUPXevbFYj2J3UGpD1jWl8kUSJoUcZ0ZOiGOLUbvHQ4ZGdGUqeYXnal0wky2g== X-Received: by 2002:a05:651c:50f:b0:293:4fff:422e with SMTP id o15-20020a05651c050f00b002934fff422emr4780096ljp.16.1677086602368; Wed, 22 Feb 2023 09:23:22 -0800 (PST) Received: from localhost.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id p2-20020a2e93c2000000b0029477417d80sm721513ljh.85.2023.02.22.09.23.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 09:23:21 -0800 (PST) From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Miquel Raynal , Michael Walle , gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, u-boot@lists.denx.de, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Subject: [PATCH 4/4] nvmem: u-boot-env: post-process "ethaddr" env variable Date: Wed, 22 Feb 2023 18:22:45 +0100 Message-Id: <20230222172245.6313-5-zajec5@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230222172245.6313-1-zajec5@gmail.com> References: <20230222172245.6313-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Rafał Miłecki U-Boot environment variables are stored in ASCII format so "ethaddr" requires parsing into binary to make it work with Ethernet interfaces. This includes support for indexes to support #nvmem-cell-cells = <1>. Signed-off-by: Rafał Miłecki --- drivers/nvmem/Kconfig | 1 + drivers/nvmem/u-boot-env.c | 25 +++++++++++++++++++++++++ 2 files changed, 26 insertions(+) diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig index 189ea85bd67d..71322ea7cf53 100644 --- a/drivers/nvmem/Kconfig +++ b/drivers/nvmem/Kconfig @@ -346,6 +346,7 @@ config NVMEM_U_BOOT_ENV tristate "U-Boot environment variables support" depends on OF && MTD select CRC32 + select GENERIC_NET_UTILS help U-Boot stores its setup as environment variables. This driver adds support for verifying & exporting such data. It also exposes variables diff --git a/drivers/nvmem/u-boot-env.c b/drivers/nvmem/u-boot-env.c index 29b1d87a3c51..1f5d8aba98bf 100644 --- a/drivers/nvmem/u-boot-env.c +++ b/drivers/nvmem/u-boot-env.c @@ -4,6 +4,8 @@ */ #include +#include +#include #include #include #include @@ -70,6 +72,27 @@ static int u_boot_env_read(void *context, unsigned int offset, void *val, return 0; } +static int u_boot_env_read_post_process_ethaddr(void *context, const char *id, int index, + unsigned int offset, void **data, size_t *bytes) +{ + u8 mac[ETH_ALEN]; + + if (*bytes != 3 * ETH_ALEN - 1) + return -EINVAL; + + if (!mac_pton(*data, mac)) + return -EINVAL; + + if (index) + eth_addr_add(mac, index); + + /* We need *smaller* buffer so don't bother to krealloc() */ + ether_addr_copy(*data, mac); + *bytes = ETH_ALEN; + + return 0; +} + static int u_boot_env_add_cells(struct u_boot_env *priv, uint8_t *buf, size_t data_offset, size_t data_len) { @@ -101,6 +124,8 @@ static int u_boot_env_add_cells(struct u_boot_env *priv, uint8_t *buf, priv->cells[idx].offset = data_offset + value - data; priv->cells[idx].bytes = strlen(value); priv->cells[idx].np = of_get_child_by_name(dev->of_node, priv->cells[idx].name); + if (!strcmp(var, "ethaddr")) + priv->cells[idx].read_post_process = u_boot_env_read_post_process_ethaddr; } if (WARN_ON(idx != priv->ncells)) -- 2.34.1