Re: [PATCH mptcp-next] mptcp: add ro_after_init for tcp{,v6}_prot_override

[Geliang Tang <geliang.tang@suse.com>]

On Thu, Feb 23, 2023 at 10:10:25AM +0100, Matthieu Baerts wrote:
> Hi Geliang,
> 
> Thank you for this patch!
> 
> On 23/02/2023 04:37, Geliang Tang wrote:
> > Add __ro_after_init labels for the variables tcp_prot_override and
> > tcpv6_prot_override, just like other variables adjacent to them, to
> > indicate that they are initialised from the init hoos and no writes
> 
> (Do you mean s/hoos/hook/?)

Yes, it should be 'hooks'. Please fix this for me.

> 
> > occur afterwards.
> 
> Good catch!
> 
> Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> 
> Do you mind if I change the target to mptcp-net and add a Fixes tag when
> applying this patch?
> 
> Fixes: b19bc2945b40 ("mptcp: implement delegated actions")

Fixes: 51fa7f8ebf0e2 ("mptcp: mark ops structures as ro_after_init")
Maybe this fixes tag is better, WDYT?

Thanks,
-Geliang

> 
> Cheers,
> Matt
> -- 
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net