All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/audit: force arm mode instead of Thumb mode
Date: Thu, 23 Feb 2023 22:42:01 +0100	[thread overview]
Message-ID: <20230223224201.0e351b16@windsurf> (raw)
In-Reply-To: <20230223062259.GJ2718518@scaer>

Hello Yann,

On Thu, 23 Feb 2023 07:22:59 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> > +# src/libev has some assembly function that is not present in Thumb mode:
> > +# Error: selected processor does not support `mcr p15,0,r3,c7,c10,5' in Thumb mode
> > +# so, we desactivate Thumb mode
> > +ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
> > +AUDIT_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -marm"
> > +endif  
> 
> But then it would not work on systems that have a armv7m: BR2_cortex_m3,
> BR2_cortex_m4, or BR2_cortex_m7.

BR2_ARM_INSTRUCTIONS_THUMB is for "classic" Thumb, not Thumb2.
BR2_ARM_INSTRUCTIONS_THUMB2 is used for Thumb2 platforms, such as
ARMv7-M.

So the above condition will only trigger for ARMv4/ARMv5/ARMv6 cores,
and they all support both classic Thumb and regular ARM instruction set.

So to me, the above proposal from Fabrice works fine.

> I looked at the code, and it's going to be very complex to patch it to
> support armv7m, i.e. thumb-only.

Thumb2-only, which is totally different.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-02-23 21:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-22 14:35 [Buildroot] [PATCH 1/1] package/audit: force arm mode instead of Thumb mode Fabrice Fontaine
2023-02-23  6:22 ` Yann E. MORIN
2023-02-23  6:41   ` Yann E. MORIN
2023-02-23 21:42   ` Thomas Petazzoni via buildroot [this message]
2023-03-09 21:43     ` Arnout Vandecappelle
2023-03-16 21:35 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230223224201.0e351b16@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.