All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>,
	Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH nft] meta: introduce broute expression
Date: Fri, 24 Feb 2023 00:06:52 +0100	[thread overview]
Message-ID: <20230223230652.GE26596@breakpoint.cc> (raw)
In-Reply-To: <20230223202942.16459-1-sriram.yagnaraman@est.tech>

Sriram Yagnaraman <sriram.yagnaraman@est.tech> wrote:
>  static bool meta_key_is_unqualified(enum nft_meta_keys key)
> diff --git a/src/parser_bison.y b/src/parser_bison.y
> index 824e5db8..e3440b2b 100644
> --- a/src/parser_bison.y
> +++ b/src/parser_bison.y
> @@ -528,6 +528,7 @@ int nft_lex(void *, void *, void *);
>  %token OIFGROUP			"oifgroup"
>  %token CGROUP			"cgroup"
>  %token TIME			"time"
> +%token BROUTE 			"broute"

I think you don't need to add a new token.
meta_key_parse() should pick this up from the meta_template
array automatically.

> index bc5b5b62..f1ffa053 100644
> --- a/src/scanner.l
> +++ b/src/scanner.l
> @@ -721,6 +721,7 @@ addrstring	({macaddr}|{ip4addr}|{ip6addr})
>  "iifgroup"		{ return IIFGROUP; }
>  "oifgroup"		{ return OIFGROUP; }
>  "cgroup"		{ return CGROUP; }
> +"broute"		{ return BROUTE; }

and this should not be needed either.

      reply	other threads:[~2023-02-23 23:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 20:29 [PATCH nft] meta: introduce broute expression Sriram Yagnaraman
2023-02-23 23:06 ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230223230652.GE26596@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=sriram.yagnaraman@est.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.