All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Martin Böh via buildroot" <buildroot@buildroot.org>
Cc: "Gwenhael Goavec-Merou" <gwenhael.goavec-merou@trabucayre.com>,
	"Martin Böh" <contact@martb.dev>
Subject: Re: [Buildroot] [PATCH 1/1] package/gr-osmosdr: add support for HACKRF receivers
Date: Thu, 23 Feb 2023 23:33:31 +0100	[thread overview]
Message-ID: <20230223233331.75b619b1@windsurf> (raw)
In-Reply-To: <20230223201817.224238-1-contact@martb.dev>

Hello Martin,

On Thu, 23 Feb 2023 21:18:17 +0100
Martin Böh via buildroot <buildroot@buildroot.org> wrote:

> +config BR2_PACKAGE_GR_OSMOSDR_HACKRF
> +	bool "Osmocom HACKRF support"
> +	depends on BR2_PACKAGE_HACKRF

We would normally use a select BR2_PACKAGE_HACKRF here, which means you
have to replicate the depends on from hackrf:

        depends on !BR2_STATIC_LIBS # hackrf
        depends on BR2_TOOLCHAIN_HAS_THREADS # hackrf
        depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # hackrf

and the corresponding Config.in comment:

comment "hackrf support needs a toolchain w/ threads, dynamic library, gcc >= 4.9"
        depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS || \
                !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-02-23 22:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 20:18 [Buildroot] [PATCH 1/1] package/gr-osmosdr: add support for HACKRF receivers Martin Böh via buildroot
2023-02-23 22:33 ` Thomas Petazzoni via buildroot [this message]
2023-08-30 20:39 ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230223233331.75b619b1@windsurf \
    --to=buildroot@buildroot.org \
    --cc=contact@martb.dev \
    --cc=gwenhael.goavec-merou@trabucayre.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.