From: Stephen Hemminger <stephen@networkplumber.org>
To: Tanzeel-inline <tanxeel1.ahmed@gmail.com>
Cc: olivier.matz@6wind.com, thomas@monjalon.net,
tanzeelahmed713@gmail.com, dev@dpdk.org
Subject: Re: [PATCH v3] lib/net: add MPLS insert and strip functionality
Date: Fri, 24 Feb 2023 08:29:07 -0800 [thread overview]
Message-ID: <20230224082907.004773be@hermes.local> (raw)
In-Reply-To: <20230224112521.27-1-tanxeel1.ahmed@gmail.com>
On Fri, 24 Feb 2023 16:25:21 +0500
Tanzeel-inline <tanxeel1.ahmed@gmail.com> wrote:
> + oh = rte_pktmbuf_mtod(*m, struct rte_ether_hdr *);
> + nh = (struct rte_ether_hdr *)(void *)
> + rte_pktmbuf_prepend(*m, sizeof(struct rte_mpls_hdr));
Don't need void * cast. Can cast result of prepend (char *) to ether header directly.
Note: rte_pktmbuf_append/prepend should have been written initially to
return void * to reduce the number of casts.
next prev parent reply other threads:[~2023-02-24 16:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 22:43 [PATCH v2] lib/net: add MPLS insert and strip functionality Tanzeel-inline
2023-02-24 11:25 ` [PATCH v3] " Tanzeel-inline
2023-02-24 16:29 ` Stephen Hemminger [this message]
2023-02-25 13:53 ` [PATCH v4] " Tanzeel-inline
2023-03-09 18:35 ` Tanzeel Ahmed
2023-04-18 13:18 ` Tanzeel Ahmed
2023-05-20 19:53 ` Tanzeel Ahmed
2023-06-05 9:31 ` Olivier Matz
2023-06-10 20:17 ` [PATCH v5] " Tanzeel-inline
2023-06-22 19:47 ` Tanzeel Ahmed
-- strict thread matches above, loose matches on Subject: below --
2023-02-24 11:06 [PATCH v3] " Tanzeel-inline
2024-10-03 18:46 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224082907.004773be@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=tanxeel1.ahmed@gmail.com \
--cc=tanzeelahmed713@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.