All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Neanne <jneanne@baylibre.com>
To: linus.walleij@linaro.org, brgl@bgdev.pl, tony@atomide.com,
	lee@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-omap@vger.kernel.org, Jerome Neanne <jneanne@baylibre.com>,
	Jonathan Cormier <jcormier@criticallink.com>
Subject: [PATCH 2/2] mfd: tps65219: Add gpio cell instance
Date: Fri, 24 Feb 2023 12:38:37 +0100	[thread overview]
Message-ID: <20230224113837.874264-3-jneanne@baylibre.com> (raw)
In-Reply-To: <20230224113837.874264-1-jneanne@baylibre.com>

tps65219 PMIC GPIOs are exposed in a standard way:
gpiodetect
gpiochip0 [tps65219-gpio] (3 lines)

Signed-off-by: Jonathan Cormier <jcormier@criticallink.com>
Signed-off-by: Jerome Neanne <jneanne@baylibre.com>
---
 drivers/mfd/tps65219.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/tps65219.c b/drivers/mfd/tps65219.c
index c134f3f6e202..5ce62e480ff9 100644
--- a/drivers/mfd/tps65219.c
+++ b/drivers/mfd/tps65219.c
@@ -115,7 +115,7 @@ static const struct mfd_cell tps65219_cells[] = {
 		.resources = tps65219_regulator_resources,
 		.num_resources = ARRAY_SIZE(tps65219_regulator_resources),
 	},
-	{ .name = "tps65219-gpios", },
+	{ .name = "tps65219-gpio", },
 };
 
 static const struct mfd_cell tps65219_pwrbutton_cell = {
@@ -267,6 +267,11 @@ static int tps65219_probe(struct i2c_client *client)
 		return ret;
 	}
 
+	if (ret) {
+		dev_err(tps->dev, "Failed to add gpio: %d\n", ret);
+		return ret;
+	}
+
 	pwr_button = of_property_read_bool(tps->dev->of_node, "ti,power-button");
 	if (pwr_button) {
 		ret = devm_mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO,
-- 
2.34.1


  parent reply	other threads:[~2023-02-24 11:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24 11:38 [PATCH 0/2] Add support for TI TPS65219 PMIC GPIO interface Jerome Neanne
2023-02-24 11:38 ` [PATCH 1/2] gpio: tps65219: add GPIO support for TPS65219 PMIC Jerome Neanne
2023-02-24 12:16   ` andy.shevchenko
2023-02-24 12:18     ` andy.shevchenko
2023-02-27 19:20     ` Jon Cormier
2023-02-27 19:51       ` Andy Shevchenko
2023-02-28 11:18         ` jerome Neanne
2023-02-24 11:38 ` Jerome Neanne [this message]
2023-02-24 12:17   ` [PATCH 2/2] mfd: tps65219: Add gpio cell instance andy.shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230224113837.874264-3-jneanne@baylibre.com \
    --to=jneanne@baylibre.com \
    --cc=brgl@bgdev.pl \
    --cc=jcormier@criticallink.com \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.