From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Yunsheng Lin <linyunsheng@huawei.com>
Subject: Re: [PATCH v2 net] net: fix __dev_kfree_skb_any() vs drop monitor
Date: Fri, 24 Feb 2023 11:41:24 -0800 [thread overview]
Message-ID: <20230224114124.66f65713@kernel.org> (raw)
In-Reply-To: <20230223083845.1555914-1-edumazet@google.com>
On Thu, 23 Feb 2023 08:38:45 +0000 Eric Dumazet wrote:
> dev_kfree_skb() is aliased to consume_skb().
>
> When a driver is dropping a packet by calling dev_kfree_skb_any()
> we should propagate the drop reason instead of pretending
> the packet was consumed.
>
> Note: Now we have enum skb_drop_reason we could remove
> enum skb_free_reason (for linux-6.4)
>
> v2: added an unlikely(), suggested by Yunsheng Lin.
Applied, thanks!
prev parent reply other threads:[~2023-02-24 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 8:38 [PATCH v2 net] net: fix __dev_kfree_skb_any() vs drop monitor Eric Dumazet
2023-02-23 9:19 ` Yunsheng Lin
2023-02-24 19:41 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224114124.66f65713@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.