From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 285FCC64ED6 for ; Mon, 27 Feb 2023 05:53:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id A7AB0400B8; Mon, 27 Feb 2023 05:53:17 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A7AB0400B8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1677477197; bh=5FJIJc1t/IC3J6uR7RClNfNi+qhCMggGl8MynJMZ96Q=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=nPGxVDgRHnb3Pslb8uuUAkxcZ9EdztwzCXRnu2TBpbzETMvteQdMorBCyKonzv9uZ lX1dlG2jrerg2e8+ovcLF2c7gFho6K5iyvgMUdiguVIxVR/jDJKrFilo2jSyIszF7u agQPkXW/Vw0JoN8Ad6Hp+QUfNfq0JM/6DNYbSUm4NpifBwAs9YH8go0gN9sjEly+ob KBKTjqBMh+eyT9Honf1p+fkxj2stAGljJd79TrbJJGAphHdZ+oQ8AOceiQ1MdVbWZc AngAW+UWfd/qOei+g1nBHDKvCSgfzixFFR1cn6c4GtAVqrGqOFoQ41mQpqFSIQLDx3 MUsXEl8YQL0Ww== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id al3QpTblsez9; Mon, 27 Feb 2023 05:53:16 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id A1AC740111; Mon, 27 Feb 2023 05:53:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A1AC740111 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 13B0B1BF406 for ; Mon, 27 Feb 2023 05:53:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id DEE6D402F4 for ; Mon, 27 Feb 2023 05:53:14 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org DEE6D402F4 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rbX2HlFT8uhs for ; Mon, 27 Feb 2023 05:53:13 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5C27340343 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by smtp4.osuosl.org (Postfix) with ESMTPS id 5C27340343 for ; Mon, 27 Feb 2023 05:53:13 +0000 (UTC) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWWRK-0008Db-1o; Mon, 27 Feb 2023 06:52:46 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pWWRF-00059C-Aw; Mon, 27 Feb 2023 06:52:41 +0100 Date: Mon, 27 Feb 2023 06:52:41 +0100 From: Oleksij Rempel To: Mark Brown Message-ID: <20230227055241.GC8437@pengutronix.de> References: <20230211074113.2782508-1-o.rempel@pengutronix.de> <20230211074113.2782508-6-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: intel-wired-lan@lists.osuosl.org Subject: Re: [Intel-wired-lan] [PATCH net-next v8 5/9] net: phy: add genphy_c45_ethtool_get/set_eee() support X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Alexandre Torgue , Eric Dumazet , linux-amlogic@lists.infradead.org, Arun.Ramadoss@microchip.com, Florian Fainelli , Jose Abreu , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Paolo Abeni , Vivien Didelot , Woojung Huh , Wei Fang , Giuseppe Cavallaro , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, kernel@pengutronix.de, Vladimir Oltean , "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Hi Mark, On Sun, Feb 26, 2023 at 06:06:48PM +0000, Mark Brown wrote: > On Sat, Feb 11, 2023 at 08:41:09AM +0100, Oleksij Rempel wrote: > > Add replacement for phy_ethtool_get/set_eee() functions. > > > > Current phy_ethtool_get/set_eee() implementation is great and it is > > possible to make it even better: > > - this functionality is for devices implementing parts of IEEE 802.3 > > specification beyond Clause 22. The better place for this code is > > phy-c45.c > > Currently mainline is failing to bring up networking on the Libre > Computer AML-S905X-CC, with a bisect pointing at this commit, > 022c3f87f88 upstream (although I'm not 100% sure I trust the bisect it > seems to be in roughly the right place). I've not dug into what's going > on more than running the bisect yet. Can you please test following fixes: https://lore.kernel.org/all/167715661799.11159.2057121677394149658.git-patchwork-notify@kernel.org/ https://lore.kernel.org/all/20230225071644.2754893-1-o.rempel@pengutronix.de/ Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 497D7C64ED8 for ; Mon, 27 Feb 2023 05:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jBJEYVU809/+io1XL3nygLKqJBnuTE2UdKNizRuS/pA=; b=VbVytL/wp4bgAU fRxhpLIGA1ByrMN6SEwULcePo5yu37ZaXktQFelKx5VDi47YxTCYCcT/gr/TScdf/Lsf2+iODQI/i F2e1SJE67P14CdMlKy87HpD41H4HzozSiQt8KMLygC515C0Kpva8WgcyXKKILgy7itP7U59dPZeE3 YjtFnzW+Ej7YKzfH1869bsQD9j1gh0W291uhmut/zUTTKPTO4rJPrVF1xZg67YJ0t4KYxGOdvmX1w SoBVTuta088QkYo9a/qUGAU71qKGRfWOFudXvlA0cAx1NJ7enQavyp+JpoyhPZvQmpmKddvUOSncK E9wBJtPQcv5k4+CRaujw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWWS6-008XKV-44; Mon, 27 Feb 2023 05:53:34 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWWRu-008XIW-Li for linux-amlogic@lists.infradead.org; Mon, 27 Feb 2023 05:53:24 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWWRK-0008Db-1o; Mon, 27 Feb 2023 06:52:46 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pWWRF-00059C-Aw; Mon, 27 Feb 2023 06:52:41 +0100 Date: Mon, 27 Feb 2023 06:52:41 +0100 From: Oleksij Rempel To: Mark Brown Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, Jose Abreu , Alexandre Torgue , Giuseppe Cavallaro Subject: Re: [PATCH net-next v8 5/9] net: phy: add genphy_c45_ethtool_get/set_eee() support Message-ID: <20230227055241.GC8437@pengutronix.de> References: <20230211074113.2782508-1-o.rempel@pengutronix.de> <20230211074113.2782508-6-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-amlogic@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230226_215322_758277_0853D24B X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Mark, On Sun, Feb 26, 2023 at 06:06:48PM +0000, Mark Brown wrote: > On Sat, Feb 11, 2023 at 08:41:09AM +0100, Oleksij Rempel wrote: > > Add replacement for phy_ethtool_get/set_eee() functions. > > > > Current phy_ethtool_get/set_eee() implementation is great and it is > > possible to make it even better: > > - this functionality is for devices implementing parts of IEEE 802.3 > > specification beyond Clause 22. The better place for this code is > > phy-c45.c > > Currently mainline is failing to bring up networking on the Libre > Computer AML-S905X-CC, with a bisect pointing at this commit, > 022c3f87f88 upstream (although I'm not 100% sure I trust the bisect it > seems to be in roughly the right place). I've not dug into what's going > on more than running the bisect yet. Can you please test following fixes: https://lore.kernel.org/all/167715661799.11159.2057121677394149658.git-patchwork-notify@kernel.org/ https://lore.kernel.org/all/20230225071644.2754893-1-o.rempel@pengutronix.de/ Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23FF5C64ED6 for ; Mon, 27 Feb 2023 05:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jQp701s60T/fGE1Ar2StPTguzHmRFWrPd1PVpzJhgwY=; b=IR4tdJLtYIYnDE YcovwT52bfkX/NVURAtGF/EIeM2DR9DgZlK2weARQy23U4Ovb5k11T0zveP7geEUlTcZ6fW1GjdD5 t4RktoxKIs2w3fpRGvzTVt6xPPGairzODEl2bJoEl153ydy7H0p27WSb/91MIb6dWMBXL+a4k2TOT +lQIgONf+69ivAWS/uigdKR7KZKgeOtXH9OqwLanLGZJEOrvbBrkH5YhCQhQJ2BmMP83KSq+uSrfM kE//rwCvNiJo4T46GcFnOTLVfei4Fz2DnGCzebMnKf+YqPXD5j7Fy+a5R21tpRxcmp3QxfunxnmKi poZ4U439QEp93BRfiLKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWWRz-008XK1-2q; Mon, 27 Feb 2023 05:53:27 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWWRu-008XIQ-Ld for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 05:53:24 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWWRK-0008Db-1o; Mon, 27 Feb 2023 06:52:46 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pWWRF-00059C-Aw; Mon, 27 Feb 2023 06:52:41 +0100 Date: Mon, 27 Feb 2023 06:52:41 +0100 From: Oleksij Rempel To: Mark Brown Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, Jose Abreu , Alexandre Torgue , Giuseppe Cavallaro Subject: Re: [PATCH net-next v8 5/9] net: phy: add genphy_c45_ethtool_get/set_eee() support Message-ID: <20230227055241.GC8437@pengutronix.de> References: <20230211074113.2782508-1-o.rempel@pengutronix.de> <20230211074113.2782508-6-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230226_215322_758264_1E150BA3 X-CRM114-Status: GOOD ( 21.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mark, On Sun, Feb 26, 2023 at 06:06:48PM +0000, Mark Brown wrote: > On Sat, Feb 11, 2023 at 08:41:09AM +0100, Oleksij Rempel wrote: > > Add replacement for phy_ethtool_get/set_eee() functions. > > > > Current phy_ethtool_get/set_eee() implementation is great and it is > > possible to make it even better: > > - this functionality is for devices implementing parts of IEEE 802.3 > > specification beyond Clause 22. The better place for this code is > > phy-c45.c > > Currently mainline is failing to bring up networking on the Libre > Computer AML-S905X-CC, with a bisect pointing at this commit, > 022c3f87f88 upstream (although I'm not 100% sure I trust the bisect it > seems to be in roughly the right place). I've not dug into what's going > on more than running the bisect yet. Can you please test following fixes: https://lore.kernel.org/all/167715661799.11159.2057121677394149658.git-patchwork-notify@kernel.org/ https://lore.kernel.org/all/20230225071644.2754893-1-o.rempel@pengutronix.de/ Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6825C64ED6 for ; Mon, 27 Feb 2023 05:53:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbjB0FxJ (ORCPT ); Mon, 27 Feb 2023 00:53:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbjB0FxG (ORCPT ); Mon, 27 Feb 2023 00:53:06 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DF2FD535 for ; Sun, 26 Feb 2023 21:52:58 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWWRK-0008Db-1o; Mon, 27 Feb 2023 06:52:46 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pWWRF-00059C-Aw; Mon, 27 Feb 2023 06:52:41 +0100 Date: Mon, 27 Feb 2023 06:52:41 +0100 From: Oleksij Rempel To: Mark Brown Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, Jose Abreu , Alexandre Torgue , Giuseppe Cavallaro Subject: Re: [PATCH net-next v8 5/9] net: phy: add genphy_c45_ethtool_get/set_eee() support Message-ID: <20230227055241.GC8437@pengutronix.de> References: <20230211074113.2782508-1-o.rempel@pengutronix.de> <20230211074113.2782508-6-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On Sun, Feb 26, 2023 at 06:06:48PM +0000, Mark Brown wrote: > On Sat, Feb 11, 2023 at 08:41:09AM +0100, Oleksij Rempel wrote: > > Add replacement for phy_ethtool_get/set_eee() functions. > > > > Current phy_ethtool_get/set_eee() implementation is great and it is > > possible to make it even better: > > - this functionality is for devices implementing parts of IEEE 802.3 > > specification beyond Clause 22. The better place for this code is > > phy-c45.c > > Currently mainline is failing to bring up networking on the Libre > Computer AML-S905X-CC, with a bisect pointing at this commit, > 022c3f87f88 upstream (although I'm not 100% sure I trust the bisect it > seems to be in roughly the right place). I've not dug into what's going > on more than running the bisect yet. Can you please test following fixes: https://lore.kernel.org/all/167715661799.11159.2057121677394149658.git-patchwork-notify@kernel.org/ https://lore.kernel.org/all/20230225071644.2754893-1-o.rempel@pengutronix.de/ Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |