From: Jakub Kicinski <kuba@kernel.org>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Guenter Roeck <groeck@google.com>,
Martin Faltesek <mfaltesek@google.com>,
Duoming Zhou <duoming@zju.edu.cn>,
Samuel Ortiz <sameo@linux.intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
lvc-project@linuxtesting.org,
syzbot+df64c0a2e8d68e78a4fa@syzkaller.appspotmail.com
Subject: Re: [PATCH] nfc: fix memory leak of se_io context in nfc_genl_se_io
Date: Mon, 27 Feb 2023 11:23:59 -0800 [thread overview]
Message-ID: <20230227112359.6df702e3@kernel.org> (raw)
In-Reply-To: <20230225105614.379382-1-pchelkin@ispras.ru>
On Sat, 25 Feb 2023 13:56:14 +0300 Fedor Pchelkin wrote:
> The callback context for sending/receiving APDUs to/from the selected
> secure element is allocated inside nfc_genl_se_io and supposed to be
> eventually freed in se_io_cb callback function. However, there are several
> error paths where the bwi_timer is not charged to call se_io_cb later, and
> the cb_context is leaked.
>
> The patch proposes to free the cb_context explicitly on those error paths.
>
> At the moment we can't simply check 'dev->ops->se_io()' return value as it
> may be negative in both cases: when the timer was charged and was not.
FWIW this patch has already been applied, please send the next changes
on top:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=25ff6f8a5a3b8dc48e8abda6f013e8cc4b14ffea
next prev parent reply other threads:[~2023-02-27 19:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 10:56 [PATCH] nfc: fix memory leak of se_io context in nfc_genl_se_io Fedor Pchelkin
2023-02-27 10:08 ` Krzysztof Kozlowski
2023-02-27 15:05 ` Fedor Pchelkin
2023-02-28 10:14 ` Krzysztof Kozlowski
2023-02-28 11:25 ` Fedor Pchelkin
2023-03-06 15:27 ` Krzysztof Kozlowski
2023-02-27 19:23 ` Jakub Kicinski [this message]
2023-03-04 16:44 ` Fedor Pchelkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227112359.6df702e3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=duoming@zju.edu.cn \
--cc=edumazet@google.com \
--cc=groeck@google.com \
--cc=khoroshilov@ispras.ru \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mfaltesek@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pchelkin@ispras.ru \
--cc=sameo@linux.intel.com \
--cc=syzbot+df64c0a2e8d68e78a4fa@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.