From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <simon.horman@corigine.com>
Cc: Pedro Tammela <pctammela@mojatatu.com>,
netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, amir@vadai.me,
dcaratti@redhat.com, willemb@google.com, ozsh@nvidia.com,
paulb@nvidia.com
Subject: Re: [PATCH net 1/3] net/sched: act_pedit: fix action bind logic
Date: Mon, 27 Feb 2023 11:36:41 -0800 [thread overview]
Message-ID: <20230227113641.574dd3bf@kernel.org> (raw)
In-Reply-To: <Y/o0BDsoepfkakiG@corigine.com>
On Sat, 25 Feb 2023 17:15:00 +0100 Simon Horman wrote:
> > > OTOH, perhaps it's a regression wrt the oldest of
> > > the two patches references below.
> >
> > ...because filters and actions are completely separate TC objects.
> > There shouldn't be actions that can be created independently but can't be
> > really used.
>
> I agree that shouldn't be the case.
> For me that doesn't make it a bug, but I don't feel strongly about it.
I'm with Simon - this is a long standing problem, and we weren't getting
any user complaints about this. So I also prefer to route this via
net-next, without the Fixes tags.
next prev parent reply other threads:[~2023-02-27 19:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 15:00 [PATCH net 0/3] net/sched: fix action bind logic Pedro Tammela
2023-02-24 15:00 ` [PATCH net 1/3] net/sched: act_pedit: " Pedro Tammela
2023-02-25 13:08 ` Simon Horman
2023-02-25 13:38 ` Pedro Tammela
2023-02-25 16:15 ` Simon Horman
2023-02-27 19:36 ` Jakub Kicinski [this message]
2023-02-27 19:51 ` Jamal Hadi Salim
2023-02-27 20:04 ` Jakub Kicinski
2023-02-27 21:41 ` Jakub Kicinski
2023-02-27 21:47 ` Jamal Hadi Salim
2023-02-24 15:00 ` [PATCH net 2/3] net/sched: act_mpls: " Pedro Tammela
2023-02-25 16:17 ` Simon Horman
2023-02-24 15:00 ` [PATCH net 3/3] net/sched: act_sample: " Pedro Tammela
2023-02-25 16:20 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227113641.574dd3bf@kernel.org \
--to=kuba@kernel.org \
--cc=amir@vadai.me \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=ozsh@nvidia.com \
--cc=pabeni@redhat.com \
--cc=paulb@nvidia.com \
--cc=pctammela@mojatatu.com \
--cc=simon.horman@corigine.com \
--cc=willemb@google.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.