From: Jakub Kicinski <kuba@kernel.org>
To: Geoff Levand <geoff@infradead.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Alexander Lobakin <alexandr.lobakin@intel.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net v6 1/2] net/ps3_gelic_net: Fix RX sk_buff length
Date: Mon, 27 Feb 2023 18:20:40 -0800 [thread overview]
Message-ID: <20230227182040.75740bb6@kernel.org> (raw)
In-Reply-To: <1bf36b8e08deb3d16fafde3e88ae7cd761e4e7b3.1677377639.git.geoff@infradead.org>
On Sun, 26 Feb 2023 02:25:42 +0000 Geoff Levand wrote:
> + napi_buff = napi_alloc_frag_align(GELIC_NET_MAX_MTU,
> + GELIC_NET_RXBUF_ALIGN);
You're changing how the buffers are allocated.
> + if (unlikely(!napi_buff)) {
> + descr->skb = NULL;
> + descr->buf_addr = 0;
> + descr->buf_size = 0;
Wiping the descriptors on failure.
> + return -ENOMEM;
> + }
And generally reshuffling the code.
Once again - please don't do any of that in a bug fix.
Describe precisely what the problem is and fix that problem,
Once the fix is accepted you can send separate patches with
other improvements.
next prev parent reply other threads:[~2023-02-28 2:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 2:25 [PATCH net v6 0/2] net/ps3_gelic_net: DMA related fixes Geoff Levand
2023-02-26 2:25 ` [PATCH net v6 1/2] net/ps3_gelic_net: Fix RX sk_buff length Geoff Levand
2023-02-28 2:20 ` Jakub Kicinski [this message]
2023-02-28 15:47 ` Alexander Lobakin
2023-02-28 20:31 ` Jakub Kicinski
2023-03-05 2:07 ` Geoff Levand
2023-02-28 16:12 ` Alexander Lobakin
2023-03-26 20:38 ` Geoff Levand
2023-02-26 2:25 ` [PATCH net v6 2/2] net/ps3_gelic_net: Use dma_mapping_error Geoff Levand
2023-02-28 16:14 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227182040.75740bb6@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=alexandr.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=geoff@infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.