From: kernel test robot <lkp@intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [l1k:rpi-6.2.y-await-linktraining 24/583] drivers/gpu/drm/vc4/vc4_hdmi.c:562:5: warning: no previous prototype for function 'vc4_hdmi_connector_get_property'
Date: Tue, 28 Feb 2023 04:14:22 +0800 [thread overview]
Message-ID: <202302280418.UTQ02tZO-lkp@intel.com> (raw)
tree: https://github.com/l1k/linux rpi-6.2.y-await-linktraining
head: f3a9201f7f484c1295cdec53c1b9bd2a19ffb231
commit: c9f8918a5153ff76ca64371f8117809fbd7e68a6 [24/583] drm/vc4_hdmi: Add Broadcast RGB property to allow override of RGB range
config: arm-randconfig-r046-20230227 (https://download.01.org/0day-ci/archive/20230228/202302280418.UTQ02tZO-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project db89896bbbd2251fff457699635acbbedeead27f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/l1k/linux/commit/c9f8918a5153ff76ca64371f8117809fbd7e68a6
git remote add l1k https://github.com/l1k/linux
git fetch --no-tags l1k rpi-6.2.y-await-linktraining
git checkout c9f8918a5153ff76ca64371f8117809fbd7e68a6
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/gpu/drm/vc4/ drivers/media/i2c/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302280418.UTQ02tZO-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/vc4/vc4_hdmi.c:562:5: warning: no previous prototype for function 'vc4_hdmi_connector_get_property' [-Wmissing-prototypes]
int vc4_hdmi_connector_get_property(struct drm_connector *connector,
^
drivers/gpu/drm/vc4/vc4_hdmi.c:562:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int vc4_hdmi_connector_get_property(struct drm_connector *connector,
^
static
>> drivers/gpu/drm/vc4/vc4_hdmi.c:592:5: warning: no previous prototype for function 'vc4_hdmi_connector_set_property' [-Wmissing-prototypes]
int vc4_hdmi_connector_set_property(struct drm_connector *connector,
^
drivers/gpu/drm/vc4/vc4_hdmi.c:592:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int vc4_hdmi_connector_set_property(struct drm_connector *connector,
^
static
2 warnings generated.
vim +/vc4_hdmi_connector_get_property +562 drivers/gpu/drm/vc4/vc4_hdmi.c
551
552 /**
553 * vc4_hdmi_connector_atomic_get_property - hook for
554 * connector->atomic_get_property.
555 * @connector: Connector to get the property for.
556 * @state: Connector state to retrieve the property from.
557 * @property: Property to retrieve.
558 * @val: Return value for the property.
559 *
560 * Returns the atomic property value for a digital connector.
561 */
> 562 int vc4_hdmi_connector_get_property(struct drm_connector *connector,
563 const struct drm_connector_state *state,
564 struct drm_property *property,
565 uint64_t *val)
566 {
567 struct vc4_hdmi *vc4_hdmi = connector_to_vc4_hdmi(connector);
568 const struct vc4_hdmi_connector_state *vc4_conn_state =
569 const_conn_state_to_vc4_hdmi_conn_state(state);
570
571 if (property == vc4_hdmi->broadcast_rgb_property) {
572 *val = vc4_conn_state->broadcast_rgb;
573 } else {
574 DRM_DEBUG_ATOMIC("Unknown property [PROP:%d:%s]\n",
575 property->base.id, property->name);
576 return -EINVAL;
577 }
578
579 return 0;
580 }
581
582 /**
583 * vc4_hdmi_connector_atomic_set_property - hook for
584 * connector->atomic_set_property.
585 * @connector: Connector to set the property for.
586 * @state: Connector state to set the property on.
587 * @property: Property to set.
588 * @val: New value for the property.
589 *
590 * Sets the atomic property value for a digital connector.
591 */
> 592 int vc4_hdmi_connector_set_property(struct drm_connector *connector,
593 struct drm_connector_state *state,
594 struct drm_property *property,
595 uint64_t val)
596 {
597 struct vc4_hdmi *vc4_hdmi = connector_to_vc4_hdmi(connector);
598 struct vc4_hdmi_connector_state *vc4_conn_state =
599 conn_state_to_vc4_hdmi_conn_state(state);
600
601 if (property == vc4_hdmi->broadcast_rgb_property) {
602 vc4_conn_state->broadcast_rgb = val;
603 return 0;
604 }
605
606 DRM_DEBUG_ATOMIC("Unknown property [PROP:%d:%s]\n",
607 property->base.id, property->name);
608 return -EINVAL;
609 }
610
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
reply other threads:[~2023-02-27 20:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302280418.UTQ02tZO-lkp@intel.com \
--to=lkp@intel.com \
--cc=lukas@wunner.de \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.