From: Jakub Kicinski <kuba@kernel.org>
To: nick black <dankamongmen@gmail.com>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jeffrey Ji <jeffreyji@google.com>,
Eric Dumazet <edumazet@google.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH] [net] add rx_otherhost_dropped sysfs entry
Date: Tue, 28 Feb 2023 12:33:14 -0800 [thread overview]
Message-ID: <20230228123314.315ef444@kernel.org> (raw)
In-Reply-To: <Y/386wA5az1Yixyp@schwarzgerat.orthanc>
On Tue, 28 Feb 2023 08:08:59 -0500 nick black wrote:
> --- net/core/net-sysfs.c
> +++ net/core/net-sysfs.c
> @@ -714,6 +714,10 @@ NETSTAT_ENTRY(rx_compressed);
> NETSTAT_ENTRY(tx_compressed);
> NETSTAT_ENTRY(rx_nohandler);
>
I'd skip the empty line here to make it clear that the comment pertains
to what's above it, otherwise people may miss it.
When reposting pls make a new thread (patchwork won't pick up patches
sent with Re: at all:
https://patchwork.kernel.org/project/netdevbpf/patch/Y/386wA5az1Yixyp@schwarzgerat.orthanc/
> +/* end of old stats -- new stats via rtnetlink only. we do not want
> + * more sysfs entries.
> + */
prev parent reply other threads:[~2023-02-28 20:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 21:12 [PATCH] [net] add rx_otherhost_dropped sysfs entry nick black
2023-02-27 18:23 ` Jakub Kicinski
2023-02-27 18:29 ` nick black
2023-02-27 18:35 ` Eric Dumazet
2023-02-27 18:40 ` Jakub Kicinski
2023-02-28 12:59 ` nick black
2023-02-28 13:08 ` nick black
2023-02-28 20:33 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228123314.315ef444@kernel.org \
--to=kuba@kernel.org \
--cc=dankamongmen@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jeffreyji@google.com \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.