From: Ranjan Kumar <ranjan.kumar@broadcom.com>
To: linux-scsi@vger.kernel.org, martin.petersen@oracle.com
Cc: rajsekhar.chundru@broadcom.com, sathya.prakash@broadcom.com,
sumit.saxena@broadcom.com,
Ranjan Kumar <ranjan.kumar@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Subject: [PATCH 2/6] mpi3mr: Driver unload crash host when enhanced logging is enabled
Date: Tue, 28 Feb 2023 06:08:31 -0800 [thread overview]
Message-ID: <20230228140835.4075-3-ranjan.kumar@broadcom.com> (raw)
In-Reply-To: <20230228140835.4075-1-ranjan.kumar@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]
Driver was trying to access null pointer in a debug print
while removing a device during driver unload
Signed-off-by: Ranjan Kumar <ranjan.kumar@broadcom.com>
Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
---
drivers/scsi/mpi3mr/mpi3mr_transport.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/mpi3mr/mpi3mr_transport.c b/drivers/scsi/mpi3mr/mpi3mr_transport.c
index 3fc897336b5e..584daf8a3ac9 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_transport.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_transport.c
@@ -1552,7 +1552,8 @@ static void mpi3mr_sas_port_remove(struct mpi3mr_ioc *mrioc, u64 sas_address,
list_for_each_entry_safe(mr_sas_phy, next_phy,
&mr_sas_port->phy_list, port_siblings) {
- if ((mrioc->logging_level & MPI3_DEBUG_TRANSPORT_INFO))
+ if ((!mrioc->stop_drv_processing) &&
+ (mrioc->logging_level & MPI3_DEBUG_TRANSPORT_INFO))
dev_info(&mr_sas_port->port->dev,
"remove: sas_address(0x%016llx), phy(%d)\n",
(unsigned long long)
--
2.31.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
next prev parent reply other threads:[~2023-02-28 14:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 14:08 [PATCH 0/6] This patchset contains critical Bug fixes Ranjan Kumar
2023-02-28 14:08 ` [PATCH 1/6] mpi3mr: IOCTL timeout when disable/enable Interpt Ranjan Kumar
2023-02-28 14:08 ` Ranjan Kumar [this message]
2023-02-28 14:08 ` [PATCH 3/6] mpi3mr: Wait for diagnostic save during controller init Ranjan Kumar
2023-02-28 14:08 ` [PATCH 4/6] mpi3mr: appropriate return values for failures in firmware init path Ranjan Kumar
2023-02-28 14:08 ` [PATCH 5/6] mpi3mr: NVMe commands size greater than 8K fails Ranjan Kumar
2023-02-28 14:08 ` [PATCH 6/6] mpi3mr: Bad drive in topology results kernel crash Ranjan Kumar
2023-03-07 2:57 ` [PATCH 0/6] This patchset contains critical Bug fixes Martin K. Petersen
2023-03-27 16:13 ` Salvatore Bonaccorso
2023-04-03 1:04 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228140835.4075-3-ranjan.kumar@broadcom.com \
--to=ranjan.kumar@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rajsekhar.chundru@broadcom.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.