From: Rob Herring <robh@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] dt-bindings: leds: add "usbport" trigger
Date: Tue, 28 Feb 2023 18:02:36 -0600 [thread overview]
Message-ID: <20230301000236.GA20893-robh@kernel.org> (raw)
In-Reply-To: <20230228144933.22614-1-zajec5@gmail.com>
On Tue, Feb 28, 2023 at 03:49:33PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> It's a trigger used on many home routers that have LEDs to indicate
> specific USB port state.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index 15e3f6645682..95b316ee3146 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -99,6 +99,7 @@ properties:
> - pattern
> - usb-gadget
> - usb-host
> + - usbport
Can we stop adding entries which are clearly likely to have multiple
instances. We have a better binding to map the trigger source...
> - pattern: "^cpu[0-9]*$"
> - pattern: "^hci[0-9]+-power$"
> # LED is triggered by Bluetooth activity
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-03-01 0:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 14:49 [PATCH] dt-bindings: leds: add "usbport" trigger Rafał Miłecki
2023-02-28 21:21 ` Pavel Machek
2023-03-01 0:02 ` Rob Herring [this message]
2023-03-01 7:26 ` Rafał Miłecki
2023-03-01 13:43 ` Rob Herring
2023-03-01 13:52 ` Rafał Miłecki
2023-03-08 0:40 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301000236.GA20893-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafal@milecki.pl \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.