From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Andrew Halaney <ahalaney@redhat.com>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH 00/16] Qcom: Fix PCI I/O range defined in devicetree
Date: Wed, 1 Mar 2023 17:02:27 +0530 [thread overview]
Message-ID: <20230301113227.GE5409@thinkpad> (raw)
In-Reply-To: <20230228172952.nfjce7cjos6tume3@halaney-x13s>
On Tue, Feb 28, 2023 at 11:29:52AM -0600, Andrew Halaney wrote:
> On Tue, Feb 28, 2023 at 10:17:36PM +0530, Manivannan Sadhasivam wrote:
> > Hi,
> >
> > This series fixes the issue with PCI I/O ranges defined in devicetree of
> > Qualcomm SoCs as reported by Arnd [1]. Most of the Qualcomm SoCs define
> > identical mapping for the PCI I/O range. But the PCI device I/O ports
> > are usually located between 0x0 to 64KiB/1MiB. So the defined PCI addresses are
> > mostly bogus. The lack of bug report on this issue indicates that no one really
> > tested legacy PCI devices with these SoCs.
> >
> > This series also contains a couple of cleanup patches that aligns the entries of
> > ranges property.
> >
> > Thanks,
> > Mani
> >
> > [1] https://lore.kernel.org/linux-arm-msm/7c5dfa87-41df-4ba7-b0e4-72c8386402a8@app.fastmail.com/
> >
> > Manivannan Sadhasivam (16):
> > arm64: dts: qcom: sdm845: Fix the PCI I/O port range
> > arm64: dts: qcom: msm8998: Fix the PCI I/O port range
> > arm64: dts: qcom: sc7280: Fix the PCI I/O port range
> > arm64: dts: qcom: sm8550: Fix the PCI I/O port range
> > arm64: dts: qcom: ipq8074: Fix the PCI I/O port range
> > arm64: dts: qcom: ipq6018: Fix the PCI I/O port range
> > arm64: dts: qcom: msm8996: Fix the PCI I/O port range
> > arm64: dts: qcom: sm8250: Fix the PCI I/O port range
> > arm64: dts: qcom: qcs404: Use 0x prefix for the PCI I/O and MEM ranges
> > arm64: dts: qcom: sc8280xp: Fix the PCI I/O port range
> > arm64: dts: qcom: sm8150: Fix the PCI I/O port range
> > arm64: dts: qcom: sm8450: Fix the PCI I/O port range
> > arm64: dts: qcom: sm8350: Fix the PCI I/O port range
> > ARM: dts: qcom: apq8064: Use 0x prefix for the PCI I/O and MEM ranges
> > ARM: dts: qcom: ipq4019: Fix the PCI I/O port range
> > ARM: dts: qcom: ipq8064: Fix the PCI I/O port range
> >
> > arch/arm/boot/dts/qcom-apq8064.dtsi | 4 ++--
> > arch/arm/boot/dts/qcom-ipq4019.dtsi | 4 ++--
> > arch/arm/boot/dts/qcom-ipq8064.dtsi | 12 ++++++------
> > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 ++--
> > arch/arm64/boot/dts/qcom/ipq8074.dtsi | 12 ++++--------
> > arch/arm64/boot/dts/qcom/msm8996.dtsi | 12 ++++++------
> > arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +-
> > arch/arm64/boot/dts/qcom/qcs404.dtsi | 4 ++--
>
> Would you mind giving sa8540p.dtsi to similiar treatment? I will admit
> I know next to nothing about PCI techically, so I can't even comment
> with confidence that this is needed there, but it looks similar to other
> descriptions modified in this patch series.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sa8540p.dtsi#n197
Ah, I didn't spot the separate ranges used for this SoC. Will fix it in next
revision.
Thanks,
Mani
>
> Thanks,
> Andrew
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-03-01 11:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 16:47 [PATCH 00/16] Qcom: Fix PCI I/O range defined in devicetree Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 01/16] arm64: dts: qcom: sdm845: Fix the PCI I/O port range Manivannan Sadhasivam
2023-02-28 16:55 ` Arnd Bergmann
2023-02-28 16:47 ` [PATCH 02/16] arm64: dts: qcom: msm8998: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 03/16] arm64: dts: qcom: sc7280: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 04/16] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 05/16] arm64: dts: qcom: ipq8074: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 06/16] arm64: dts: qcom: ipq6018: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 07/16] arm64: dts: qcom: msm8996: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 08/16] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 09/16] arm64: dts: qcom: qcs404: Use 0x prefix for the PCI I/O and MEM ranges Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 10/16] arm64: dts: qcom: sc8280xp: Fix the PCI I/O port range Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 11/16] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 12/16] arm64: dts: qcom: sm8450: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 13/16] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 14/16] ARM: dts: qcom: apq8064: Use 0x prefix for the PCI I/O and MEM ranges Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 15/16] ARM: dts: qcom: ipq4019: Fix the PCI I/O port range Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 16/16] ARM: dts: qcom: ipq8064: " Manivannan Sadhasivam
2023-02-28 16:58 ` [PATCH 00/16] Qcom: Fix PCI I/O range defined in devicetree Arnd Bergmann
2023-03-01 11:29 ` Manivannan Sadhasivam
2023-03-01 11:57 ` Arnd Bergmann
2023-02-28 17:29 ` Andrew Halaney
2023-03-01 11:32 ` Manivannan Sadhasivam [this message]
2023-03-16 3:20 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301113227.GE5409@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.