From: Alexander Potapenko <glider@google.com>
To: glider@google.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
x86@kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com,
akpm@linux-foundation.org, elver@google.com, dvyukov@google.com,
nathan@kernel.org, ndesaulniers@google.com,
kasan-dev@googlegroups.com
Subject: [PATCH 4/4] kmsan: add memsetXX tests
Date: Wed, 1 Mar 2023 15:39:33 +0100 [thread overview]
Message-ID: <20230301143933.2374658-4-glider@google.com> (raw)
In-Reply-To: <20230301143933.2374658-1-glider@google.com>
Add tests ensuring that memset16()/memset32()/memset64() are
instrumented by KMSAN and correctly initialize the memory.
Signed-off-by: Alexander Potapenko <glider@google.com>
---
mm/kmsan/kmsan_test.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/mm/kmsan/kmsan_test.c b/mm/kmsan/kmsan_test.c
index cc98a3f4e0899..e450a000441fb 100644
--- a/mm/kmsan/kmsan_test.c
+++ b/mm/kmsan/kmsan_test.c
@@ -503,6 +503,25 @@ static void test_memcpy_aligned_to_unaligned2(struct kunit *test)
KUNIT_EXPECT_TRUE(test, report_matches(&expect));
}
+/* Generate test cases for memset16(), memset32(), memset64(). */
+#define DEFINE_TEST_MEMSETXX(size, var_ty) \
+ static void test_memset##size(struct kunit *test) \
+ { \
+ EXPECTATION_NO_REPORT(expect); \
+ volatile var_ty uninit; \
+ \
+ kunit_info(test, \
+ "memset" #size "() should initialize memory\n"); \
+ DO_NOT_OPTIMIZE(uninit); \
+ memset##size((var_ty *)&uninit, 0, 1); \
+ kmsan_check_memory((void *)&uninit, sizeof(uninit)); \
+ KUNIT_EXPECT_TRUE(test, report_matches(&expect)); \
+ }
+
+DEFINE_TEST_MEMSETXX(16, uint16_t)
+DEFINE_TEST_MEMSETXX(32, uint32_t)
+DEFINE_TEST_MEMSETXX(64, uint64_t)
+
static noinline void fibonacci(int *array, int size, int start)
{
if (start < 2 || (start == size))
@@ -549,6 +568,9 @@ static struct kunit_case kmsan_test_cases[] = {
KUNIT_CASE(test_memcpy_aligned_to_aligned),
KUNIT_CASE(test_memcpy_aligned_to_unaligned),
KUNIT_CASE(test_memcpy_aligned_to_unaligned2),
+ KUNIT_CASE(test_memset16),
+ KUNIT_CASE(test_memset32),
+ KUNIT_CASE(test_memset64),
KUNIT_CASE(test_long_origin_chain),
{},
};
--
2.39.2.722.g9855ee24e9-goog
next prev parent reply other threads:[~2023-03-01 14:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 14:39 [PATCH 1/4] x86: kmsan: Don't rename memintrinsics in uninstrumented files Alexander Potapenko
2023-03-01 14:39 ` [PATCH 2/4] kmsan: another take at fixing memcpy tests Alexander Potapenko
2023-03-02 11:18 ` Marco Elver
2023-03-02 14:48 ` Alexander Potapenko
2023-03-01 14:39 ` [PATCH 3/4] x86: kmsan: use C versions of memset16/memset32/memset64 Alexander Potapenko
2023-03-02 11:18 ` Marco Elver
2023-03-01 14:39 ` Alexander Potapenko [this message]
2023-03-02 11:22 ` [PATCH 4/4] kmsan: add memsetXX tests Marco Elver
2023-03-02 14:14 ` Alexander Potapenko
2023-03-02 11:13 ` [PATCH 1/4] x86: kmsan: Don't rename memintrinsics in uninstrumented files Marco Elver
2023-03-02 14:27 ` Alexander Potapenko
2023-03-02 15:13 ` Marco Elver
2023-03-02 15:17 ` Alexander Potapenko
-- strict thread matches above, loose matches on Subject: below --
2023-03-03 14:14 Alexander Potapenko
2023-03-03 14:14 ` [PATCH 4/4] kmsan: add memsetXX tests Alexander Potapenko
2023-03-03 14:17 ` Alexander Potapenko
2023-03-03 15:00 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301143933.2374658-4-glider@google.com \
--to=glider@google.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=hpa@zytor.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.