From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
linux-doc@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net 0/3] tools: ynl: fix subset use and change default value for attrs/ops
Date: Wed, 1 Mar 2023 10:36:39 -0800 [thread overview]
Message-ID: <20230301183642.2168393-1-kuba@kernel.org> (raw)
Fix a problem in subsetting, which will become apparent when
the devlink family comes after the merge window. Even tho none
of the existing families need this, we don't want someone to
get "inspired" by the current, incorrect code when using specs
in other languages.
Change the default value for the first attr/op. This is a slight
behavior change so needs to go in now. The diffstat of the last
patch should serve as the clearest justification there..
Jakub Kicinski (3):
tools: ynl: fully inherit attrs in subsets
tools: ynl: use 1 as the default for first entry in attrs/ops
netlink: specs: update for codegen enumerating from 1
Documentation/netlink/specs/ethtool.yaml | 15 -----------
Documentation/netlink/specs/fou.yaml | 2 ++
Documentation/netlink/specs/netdev.yaml | 2 --
Documentation/userspace-api/netlink/specs.rst | 10 +++++--
tools/net/ynl/lib/nlspec.py | 27 ++++++++++++-------
tools/net/ynl/ynl-gen-c.py | 7 +++--
6 files changed, 32 insertions(+), 31 deletions(-)
--
2.39.2
next reply other threads:[~2023-03-01 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 18:36 Jakub Kicinski [this message]
2023-03-01 18:36 ` [PATCH net 1/3] tools: ynl: fully inherit attrs in subsets Jakub Kicinski
2023-03-01 18:36 ` [PATCH net 2/3] tools: ynl: use 1 as the default for first entry in attrs/ops Jakub Kicinski
2023-03-01 18:36 ` [PATCH net 3/3] netlink: specs: update for codegen enumerating from 1 Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301183642.2168393-1-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.