From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: rafael@kernel.org, daniel.lezcano@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Kaestle <peter@piie.net>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
platform-driver-x86@vger.kernel.org (open list:ACER ASPIRE ONE
TEMPERATURE AND FAN DRIVER)
Subject: [PATCH v5 18/18] thermal/drivers/acerhdf: Remove pointless governor test
Date: Wed, 1 Mar 2023 21:14:46 +0100 [thread overview]
Message-ID: <20230301201446.3713334-19-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20230301201446.3713334-1-daniel.lezcano@linaro.org>
The thermal zone parameter specifies the bang-bang governor.
The Kconfig selects the bang-bang governor. So it is pointless to test
if the governor was set for the thermal zone assuming it may not have
been compiled-in.
Remove the test and prevent another access into the thermal internals.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Peter Kaestle <peter@piie.net>
---
drivers/platform/x86/acerhdf.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index 61f1c3090867..71b9c1f922d9 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b/drivers/platform/x86/acerhdf.c
@@ -697,13 +697,6 @@ static int __init acerhdf_register_thermal(void)
if (ret)
return ret;
- if (strcmp(thz_dev->governor->name,
- acerhdf_zone_params.governor_name)) {
- pr_err("Didn't get thermal governor %s, perhaps not compiled into thermal subsystem.\n",
- acerhdf_zone_params.governor_name);
- return -EINVAL;
- }
-
return 0;
}
--
2.34.1
next prev parent reply other threads:[~2023-03-01 20:17 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 20:14 [PATCH v5 00/18] Self-encapsulate the thermal zone device structure Daniel Lezcano
2023-03-01 20:14 ` [PATCH v5 01/18] thermal/core: Add a thermal zone 'devdata' accessor Daniel Lezcano
2023-03-01 20:14 ` [PATCH v5 02/18] thermal/core: Use the thermal zone 'devdata' accessor in thermal located drivers Daniel Lezcano
2023-03-01 20:14 ` Daniel Lezcano
2023-03-03 11:28 ` Daniel Lezcano
2023-03-03 11:28 ` Daniel Lezcano
2023-03-03 11:55 ` Linus Walleij
2023-03-03 11:55 ` Linus Walleij
2023-03-03 15:47 ` Heiko Stübner
2023-03-03 15:47 ` Heiko Stübner
2023-03-03 16:21 ` Kunihiko Hayashi
2023-03-03 16:21 ` Kunihiko Hayashi
2023-03-01 20:14 ` [PATCH v5 03/18] thermal/core: Use the thermal zone 'devdata' accessor in hwmon " Daniel Lezcano
2023-03-01 20:14 ` [PATCH v5 04/18] thermal/core: Use the thermal zone 'devdata' accessor in remaining drivers Daniel Lezcano
2023-03-01 20:14 ` Daniel Lezcano
2023-03-01 20:14 ` Daniel Lezcano
2023-03-01 20:14 ` [PATCH v5 05/18] thermal/core: Show a debug message when get_temp() fails Daniel Lezcano
2023-03-01 20:14 ` [PATCH v5 06/18] thermal: Remove debug or error messages in get_temp() ops Daniel Lezcano
2023-03-01 20:14 ` Daniel Lezcano
2023-03-01 20:14 ` Daniel Lezcano
2023-03-03 15:47 ` Heiko Stübner
2023-03-03 15:47 ` Heiko Stübner
2023-03-03 15:47 ` Heiko Stübner
2023-03-01 20:14 ` [PATCH v5 07/18] thermal/hwmon: Do not set no_hwmon before calling thermal_add_hwmon_sysfs() Daniel Lezcano
2023-03-01 20:14 ` Daniel Lezcano
2023-03-01 20:14 ` Daniel Lezcano
2023-03-03 15:48 ` Heiko Stübner
2023-03-03 15:48 ` Heiko Stübner
2023-03-03 15:48 ` Heiko Stübner
2023-03-01 20:14 ` [PATCH v5 08/18] thermal/hwmon: Use the right device for devm_thermal_add_hwmon_sysfs() Daniel Lezcano
2023-03-01 20:14 ` Daniel Lezcano
2023-03-01 20:14 ` Daniel Lezcano
2023-03-01 20:14 ` [PATCH v5 09/18] thermal: Don't use 'device' internal thermal zone structure field Daniel Lezcano
2023-03-01 20:14 ` Daniel Lezcano
2023-03-01 20:14 ` [PATCH v5 10/18] thermal/core: Add thermal_zone_device structure 'type' accessor Daniel Lezcano
2023-03-01 20:14 ` [PATCH v5 11/18] thermal/drivers/spear: Don't use tz->device but pdev->dev Daniel Lezcano
2023-03-01 20:14 ` [PATCH v5 12/18] thermal: Add a thermal zone id accessor Daniel Lezcano
2023-03-01 20:14 ` [PATCH v5 13/18] thermal: Use thermal_zone_device_type() accessor Daniel Lezcano
2023-03-01 20:14 ` Daniel Lezcano
2023-03-01 20:14 ` [PATCH v5 14/18] thermal/drivers/da9062: Don't access the thermal zone device fields Daniel Lezcano
2023-03-01 20:14 ` [PATCH v5 15/18] thermal/hwmon: Use the thermal_core.h header Daniel Lezcano
2023-03-01 20:14 ` [PATCH v5 16/18] thermal/drivers/tegra: Remove unneeded lock when setting a trip point Daniel Lezcano
2023-03-02 9:47 ` Thierry Reding
2023-03-02 10:00 ` Daniel Lezcano
2023-03-01 20:14 ` [PATCH v5 17/18] thermal/drivers/acerhdf: Make interval setting only at module load time Daniel Lezcano
2023-03-01 20:14 ` Daniel Lezcano [this message]
2023-03-03 9:24 ` [PATCH v5 00/18] Self-encapsulate the thermal zone device structure Daniel Lezcano
2023-03-03 19:48 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301201446.3713334-19-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=peter@piie.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.