From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C632C6FA8E for ; Thu, 2 Mar 2023 23:51:12 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id D946260348 for ; Thu, 2 Mar 2023 23:51:11 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id CEA94986712 for ; Thu, 2 Mar 2023 23:51:11 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id C20E2984091; Thu, 2 Mar 2023 23:51:11 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-Id: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id B1E609866AC for ; Thu, 2 Mar 2023 23:51:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: xgYsPDI4NGeXV3DWXMdPiw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677801067; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b/okyWqbJl/R8P+UDXUPs5Vi66gHcDSAyfTaXwh0er4=; b=C+ZgiQs4HUNKSxIlS8LXEpOZ5tqkPlx3/6a6sFy9dzTp1lXF4RjpT3oUteYosFb1wT f7cMqcbRksqbSm4x8O/RSDA4cJjiutm+my+jG2kTwMydoDB8fWDVHaJjaN+MhEuewbGH PEmtg61VS/v/RbD+uQS5qQkZGswKa5ZFi/pAT185CmbQC2wMqbDcTAcOIot5VgnAyU3i vVBcVLYNf4Wd2vXtssGv2Q9TkfzVlaHeqwl7PaCkEJ7ViohvKPOup0/bM0ROUv6ReNjG mXfCxiqa7nhYb55g7Uj4i+Qi/k6cK1hC95s/keYmJs6ETdBxcaiBoGCvuCaSPqcatYWf 7Hjw== X-Gm-Message-State: AO0yUKWP4ZA9Swq1+5OmBsoS7LsRw1En2gRygfG5+rFXH1EwdmnhavYo 8baqOlSdcewyMBDlT46Mnvrm/suEzDtJGjSJcPWgg2yMDcFKBqH3CvSCknAB0+9bE23l8k7SgBX AkxFp9815QSGd7XtdQDgDWuMcVAwUmkFccg== X-Received: by 2002:a05:600c:329a:b0:3db:5f1:53a5 with SMTP id t26-20020a05600c329a00b003db05f153a5mr9831208wmp.20.1677801067421; Thu, 02 Mar 2023 15:51:07 -0800 (PST) X-Google-Smtp-Source: AK7set/MWMU38lItIDl5/uC44hWHZxSzKiZOgVyNcyGDRFQ/dXg0kB+ztODdW55HO50bpeFixFYHOQ== X-Received: by 2002:a05:600c:329a:b0:3db:5f1:53a5 with SMTP id t26-20020a05600c329a00b003db05f153a5mr9831190wmp.20.1677801067100; Thu, 02 Mar 2023 15:51:07 -0800 (PST) Date: Thu, 2 Mar 2023 18:51:03 -0500 From: "Michael S. Tsirkin" To: Parav Pandit Cc: "virtio-comment@lists.oasis-open.org" , "virtio-dev@lists.oasis-open.org" , "jasowang@redhat.com" , "cohuck@redhat.com" , "sgarzare@redhat.com" , "stefanha@redhat.com" , "nrupal.jani@intel.com" , "Piotr.Uminski@intel.com" , "hang.yuan@intel.com" , "virtio@lists.oasis-open.org" , Zhu Lingshan , "pasic@linux.ibm.com" , Shahaf Shuler , Max Gurtovoy Message-ID: <20230302184849-mutt-send-email-mst@kernel.org> References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved On Thu, Mar 02, 2023 at 06:40:55PM +0000, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, March 2, 2023 8:05 AM > > > > Adding relevant registers needs more work and it's not clear what the use-case > > will be as currently only the PCI transport is supported. But let's keep the door > > open on this. > > We already say it's reserved in a central place, but it does not hurt to remind > > implementers to mask it. > > > > Signed-off-by: Michael S. Tsirkin > > Did you miss reviewed-by from [1] or this is an old series reposted? > [1] https://lists.oasis-open.org/archives/virtio-dev/202302/msg00242.html > > I will wait for your response before reviewing more, as I am confused now between missing items of v10 of Feb and March. There was such a huge flamewar around error codes I probably just missed some useful comments among the noise. > Can you please have the per-patch change log? I learnt and practice that from netdev community. > It has been very useful to have effective reviews (especially when series is long). Can't promise really I will need to look for tooling for that. Unlikely to happen with this patch. I'm not asking others to do it either. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org