From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E0F8C678D4 for ; Thu, 2 Mar 2023 20:38:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3EADC85A80; Thu, 2 Mar 2023 21:37:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ZBV3jazl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 59817858BF; Thu, 2 Mar 2023 21:37:56 +0100 (CET) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BE13885CA1 for ; Thu, 2 Mar 2023 21:37:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf31.google.com with SMTP id f1so363270qvx.13 for ; Thu, 02 Mar 2023 12:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1677789472; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K3asDCkbVopk5VHgoJ2ka7cSqtRekx1GcAil0gtIgGY=; b=ZBV3jazlmvHJQIXG38ycjnbMu5MKLJZgsRYTS+UXcGH5FBKHgZWV7ea7Dv0+H7MSW9 4l8IrbVpG89yk0wn3vjavpaqWLVCCEk2k9O8flEMgKsBSbuag6/F+USvRqMWK5yUiLPR crzAgqAvNMJPIaNzPZVYgcRrrpTxn6O68Bsek= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677789472; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K3asDCkbVopk5VHgoJ2ka7cSqtRekx1GcAil0gtIgGY=; b=u4pM21DV4gvzlhjnuMoXtuU6Of6nWq6/V1Zr7UsOIadw5BV7R0DlWxchMAfzaqMaTL FwbK3TSNrmm1vmxLvvJ2OKBuiVhpzGrDK2hgb4/gDBOO4z5k9tCRO/XjyWMjGijA6FLx Iq0AQT7wAf60JeW3Sy5V6dm1E+GEMvZVT7WvntZVl10jtYyH15ry99no0I5KumLXxb8m P1GAorg9adxx5dz3ClePldoaYLIlcmcB4n7Q9P4RSjFYqhFzaolbpbHC0jRURS8M/cOj 44bkFj2Dh60jFXCTiww8plpOmdxvc1b2wD2BbB635gI38UmCJpeiB2VMqT06CpbsCSu4 KuMw== X-Gm-Message-State: AO0yUKX+vKu5oXTMx5Gw5ME8owdjuKMEVd2wESKwml+165ou1KYFzPZ6 TynyiQnbCnmTOX2BaBWO1GPzXQ== X-Google-Smtp-Source: AK7set/LLtJp3hS0ImAPFug7kjLKq3LIYkTDGCvt8LQZpdei0x6tPL81xXvTtawV0GeS7jj4P/Bysg== X-Received: by 2002:a05:6214:2264:b0:56f:5466:20d8 with SMTP id gs4-20020a056214226400b0056f546620d8mr22368323qvb.3.1677789472563; Thu, 02 Mar 2023 12:37:52 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0000-0000-0000-036b.res6.spectrum.com. [2603:6081:7b00:6400::36b]) by smtp.gmail.com with ESMTPSA id i65-20020a378644000000b00725d8d6983asm350757qkd.61.2023.03.02.12.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 12:37:52 -0800 (PST) Date: Thu, 2 Mar 2023 15:37:50 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Bin Meng Subject: Re: [PATCH v5 21/44] x86: Use string functions for all 32-bit builds Message-ID: <20230302203750.GA4003607@bill-the-cat> References: <20230222163425.2043934-1-sjg@chromium.org> <20230222163425.2043934-22-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="12KWGZECyubeTceQ" Content-Disposition: inline In-Reply-To: <20230222163425.2043934-22-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --12KWGZECyubeTceQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 22, 2023 at 09:34:02AM -0700, Simon Glass wrote: > At present these are not included in SPL. They do add to code size but > are a bit faster, so adjust the setting to add them. >=20 > Signed-off-by: Simon Glass > --- >=20 > (no changes since v1) >=20 > arch/x86/include/asm/string.h | 2 +- > arch/x86/lib/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/x86/include/asm/string.h b/arch/x86/include/asm/string.h > index c15b264a5c0..0254a022160 100644 > --- a/arch/x86/include/asm/string.h > +++ b/arch/x86/include/asm/string.h > @@ -14,7 +14,7 @@ extern char *strrchr(const char *s, int c); > #undef __HAVE_ARCH_STRCHR > extern char *strchr(const char *s, int c); > =20 > -#ifdef CONFIG_X86_64 > +#if CONFIG_IS_ENABLED(X86_64) > =20 > #undef __HAVE_ARCH_MEMCPY > extern void *memcpy(void *, const void *, __kernel_size_t); > diff --git a/arch/x86/lib/Makefile b/arch/x86/lib/Makefile > index a6f22441474..ea7ff2bcf38 100644 > --- a/arch/x86/lib/Makefile > +++ b/arch/x86/lib/Makefile > @@ -4,7 +4,7 @@ > # Wolfgang Denk, DENX Software Engineering, wd@denx.de. > =20 > obj-y +=3D bdinfo.o > -ifndef CONFIG_X86_64 > +ifndef CONFIG_$(SPL_TPL_)X86_64 > ifndef CONFIG_TPL_BUILD > obj-y +=3D bios.o > obj-y +=3D bios_asm.o This is just.. confusing. Please re-work the string selection code to be more direct, with a new symbol if needed. And please re-examine if SPL_X86_64 is needed as a symbol at all. --=20 Tom --12KWGZECyubeTceQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQBCR4ACgkQFHw5/5Y0 tyxxegv8DUKW3sCfezxO8cSy2PFEahPzd8Csxl2PDUOwywBvRY0U0Z+7KnSVWXy6 +3rMQT/k43MuipNoSk3A7M/SUDlXdHWWrYpCER6EAsNQn1BraSYjFwQl4l1TQWKZ T+g7OnqS6GW0zhCVl0vAGHX/odEok0s3ShpqukIQ7UR2LTj0kbNWuSdUY1d+qOsT 5ZPzKN6IO6CMkMAOuWr5+lah3fVpVTDT22P5cKF0Xfq/v4lsC3eIjChaokJeEeU5 np5RC7D6nFCAmVT7/R0BHG1e8BR1mzCNdwHXX7nfBlzJVNSIpnHWvBdDQoJvTuxN t7NnTztwFfRkfOSui/qWp7c3+hpqZxgW4vKFlWsG8k/ydDoAETMW/9C95KkW3BCc GracsfRJCMXkwlGoroK6vTxcKNkoxcBkSuvdRIpPdgZI6K+WKAJr48eicxXoChuq z9zQNPdTOUwbIGxk1F5eFskPux1hXbLBAbLSrGItbwa6L8l3/cx2H1SvFiqpP/+N ALscyqfT =krJe -----END PGP SIGNATURE----- --12KWGZECyubeTceQ--