From: Lee Jones <lee@kernel.org>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
linux-kernel@vger.kernel.org, linux@ew.tq-group.com
Subject: Re: [PATCH v2 3/3] mfd: tqmx86: correct board names for TQMxE39x
Date: Fri, 3 Mar 2023 12:05:27 +0000 [thread overview]
Message-ID: <20230303120527.GL2420672@google.com> (raw)
In-Reply-To: <aca9a7cb42a85181bcb456c437554d2728e708ec.1676892223.git.matthias.schiffer@ew.tq-group.com>
On Mon, 20 Feb 2023, Matthias Schiffer wrote:
> It seems that this driver was developed based on preliminary documentation.
> Report the correct names for all TQMxE39x variants, as they are used by
> the released hardware revisions:
>
> - Fix names for TQMxE39C1/C2 board IDs
> - Distinguish TQMxE39M and TQMxE39S, which use the same board ID
>
> The TQMxE39M/S are distinguished using the SAUC (Sanctioned Alternate
> Uses Configuration) register of the GPIO controller. This also prepares
> for the correct handling of the differences between the GPIO controllers
> of our COMe and SMARC modules.
>
> Fixes: 2f17dd34ffed ("mfd: tqmx86: IO controller with I2C, Wachdog and GPIO")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
>
> Notes:
> v2: add Reviewed-by from v1
>
> drivers/mfd/tqmx86.c | 32 +++++++++++++++++---------------
> 1 file changed, 17 insertions(+), 15 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-03-03 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 11:25 [PATCH v2 1/3] mfd: tqmx86: do not access I2C_DETECT register through io_base Matthias Schiffer
2023-02-20 11:25 ` [PATCH v2 2/3] mfd: tqmx86: specify IO port register range more precisely Matthias Schiffer
2023-03-03 12:04 ` Lee Jones
2023-02-20 11:25 ` [PATCH v2 3/3] mfd: tqmx86: correct board names for TQMxE39x Matthias Schiffer
2023-03-03 12:05 ` Lee Jones [this message]
2023-02-20 13:48 ` [PATCH v2 1/3] mfd: tqmx86: do not access I2C_DETECT register through io_base Andrew Lunn
2023-03-03 12:04 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303120527.GL2420672@google.com \
--to=lee@kernel.org \
--cc=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=matthias.schiffer@ew.tq-group.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.