From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Lee Jones <lee@kernel.org>
Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
thunder.leizhen@huawei.com, festevam@gmail.com
Subject: Re: [PATCH v6] dt-bindings: leds: Document commonly used LED triggers
Date: Fri, 3 Mar 2023 18:00:22 +0530 [thread overview]
Message-ID: <20230303123022.GA6782@thinkpad> (raw)
In-Reply-To: <20230303113945.GF2420672@google.com>
On Fri, Mar 03, 2023 at 11:39:45AM +0000, Lee Jones wrote:
> On Fri, 03 Mar 2023, Lee Jones wrote:
>
> > On Mon, 13 Feb 2023, Manivannan Sadhasivam wrote:
> >
> > > Document the commonly used LED triggers by the SoCs. Not all triggers
> > > are documented as some of them are very application specific. Most of the
> > > triggers documented here are currently used in devicetrees of many SoCs.
> > >
> > > While at it, also place the comment above the triggers (hci, mmc, wlan)
> > > to match the rest of the binding.
> > >
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > ---
> > >
> > > Changes in v6:
> > >
> > > * Rebased on top of lee/for-leds-next branch
> > > * Fixed the comment location for few triggers
> > >
> > > Changes in v5:
> > >
> > > * Rebased on top of v6.2-rc1
> > >
> > > Changes in v4:
> > >
> > > * Removed the sorting of triggers
> > > * Removed the "items" as they were not needed
> > > * Reworded the description
> > > * Dropped Zhen Lei's tested-by tag as the patch has changed
> > > * Added kbd-capslock trigger
> > >
> > > Changes in v3:
> > >
> > > * Rebased on top of v6.1-rc1
> > > * Added WLAN Rx trigger
> > > * Added tested tag from Zhen Lei
> > >
> > > Changes in v2:
> > >
> > > * Added more triggers, fixed the regex
> > > * Sorted triggers in ascending order
> > >
> > > .../devicetree/bindings/leds/common.yaml | 37 +++++++++++++++++--
> > > 1 file changed, 34 insertions(+), 3 deletions(-)
> >
> > Applied, thanks
>
> Change of plan. This doesn't apply cleanly.
>
> Could you please rebase and resubmit please?
>
Done!
Thanks,
Mani
> --
> Lee Jones [李琼斯]
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2023-03-03 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 7:21 [PATCH v6] dt-bindings: leds: Document commonly used LED triggers Manivannan Sadhasivam
2023-02-15 19:26 ` Rob Herring
2023-03-03 10:34 ` Lee Jones
2023-03-03 11:39 ` Lee Jones
2023-03-03 12:30 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303123022.GA6782@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.