From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E6CC7EE32 for ; Fri, 3 Mar 2023 21:42:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232089AbjCCVmB (ORCPT ); Fri, 3 Mar 2023 16:42:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232013AbjCCVli (ORCPT ); Fri, 3 Mar 2023 16:41:38 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D28D564226; Fri, 3 Mar 2023 13:41:25 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5E29961922; Fri, 3 Mar 2023 21:41:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF6C9C433A4; Fri, 3 Mar 2023 21:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677879684; bh=F3Q4jKopnnXfzlnJ8qnU5EeFLtFycAZFH7iwqJimz+U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PYu1+tzmVFVNHMcXwjem02t+nofCu+046ki51ynjztV7pC6snCUrcw1BlCQg8B11D yQBcSs5htchoYVio5otxJmvyoB51R9TSjngJFh/k0pmAMlKG8uWmb4QzH/fm1Tw3KL f9JVrFJqt/6lJ6QLiYpikoU8SqNlkAMOsSqqS1IWyRQtaOtHP6IOiFqV+fPZJSMFEz aTXec7xJLULCHwyb5E6DKleAxhv9/BkTBV+Qt2FrXJJWRAQ0VrJV/c0fsDI6B3gV5K JNIDZw9iU3mZP8c6odkhadX0NYGjWvxNkhQcjaG5Cu6g2aR16MgMrIAFrNC36H5xEY f6dXbDz41CFRA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Alan Stern , Jilin Yuan , Sasha Levin , hdegoede@redhat.com, alexandre.belloni@bootlin.com, dan.j.williams@intel.com, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 6.2 10/64] USB: fix memory leak with using debugfs_lookup() Date: Fri, 3 Mar 2023 16:40:12 -0500 Message-Id: <20230303214106.1446460-10-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230303214106.1446460-1-sashal@kernel.org> References: <20230303214106.1446460-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Greg Kroah-Hartman [ Upstream commit 30374434edab20e25776f8ecb4bc9d1e54309487 ] When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: Alan Stern Cc: Jilin Yuan Link: https://lore.kernel.org/r/20230106152828.3790902-1-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/core/usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c index 11b15d7b357ad..a415206cab043 100644 --- a/drivers/usb/core/usb.c +++ b/drivers/usb/core/usb.c @@ -998,7 +998,7 @@ static void usb_debugfs_init(void) static void usb_debugfs_cleanup(void) { - debugfs_remove(debugfs_lookup("devices", usb_debug_root)); + debugfs_lookup_and_remove("devices", usb_debug_root); } /* -- 2.39.2