From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B69ACC7EE32 for ; Fri, 3 Mar 2023 21:44:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232209AbjCCVoP (ORCPT ); Fri, 3 Mar 2023 16:44:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231641AbjCCVnx (ORCPT ); Fri, 3 Mar 2023 16:43:53 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACF0A211D; Fri, 3 Mar 2023 13:42:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D101261932; Fri, 3 Mar 2023 21:42:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB4A7C433EF; Fri, 3 Mar 2023 21:42:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677879736; bh=FUCWLS/7vbF+P+R1E0PQ2GUZNu+Szjwa/c5dSR33D+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=adp1YcdYWszV0alrf3daZo1LFCnT8THlaOyOkSe24uxa1ywMzfhNs7khCGzovHR+H o5NvPtRziXOY801TeNl9e13AeC8Aq2WYpB3kdYZx5pY3kEWuwSBcwlDcA8FA9DhoUK mzQaTTJeFoEeD/2uDsTdt7vJCI6EepJTu9OJNWGSx1eqh+TeWL5xItIKQHXypCfZpt Rj+KOsfJ+rXyXJ4c04S9mfusYivVpPO2uSmnCjZL8f51ZNu4yN0HwGLKWCiwM0AUAv P7xkqydpMLzCiRgWhTopkDlQzS4tGtcYcl4sZxR1rHuX2nxba4n93rAAhDw8Iq5Q4b eajDkw7kyHMLw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Peter Chen , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 6.2 31/64] USB: chipidea: fix memory leak with using debugfs_lookup() Date: Fri, 3 Mar 2023 16:40:33 -0500 Message-Id: <20230303214106.1446460-31-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230303214106.1446460-1-sashal@kernel.org> References: <20230303214106.1446460-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Greg Kroah-Hartman [ Upstream commit ff35f3ea3baba5b81416ac02d005cfbf6dd182fa ] When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: Peter Chen Link: https://lore.kernel.org/r/20230202153235.2412790-1-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/chipidea/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c index faf6b078b6c44..bbc610e5bd69c 100644 --- a/drivers/usb/chipidea/debug.c +++ b/drivers/usb/chipidea/debug.c @@ -364,5 +364,5 @@ void dbg_create_files(struct ci_hdrc *ci) */ void dbg_remove_files(struct ci_hdrc *ci) { - debugfs_remove(debugfs_lookup(dev_name(ci->dev), usb_debug_root)); + debugfs_lookup_and_remove(dev_name(ci->dev), usb_debug_root); } -- 2.39.2