From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D35CBC7EE45 for ; Fri, 3 Mar 2023 21:56:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233117AbjCCVz7 (ORCPT ); Fri, 3 Mar 2023 16:55:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233297AbjCCVzS (ORCPT ); Fri, 3 Mar 2023 16:55:18 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F06206B32E; Fri, 3 Mar 2023 13:48:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A1F8D61899; Fri, 3 Mar 2023 21:42:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5218BC4339B; Fri, 3 Mar 2023 21:42:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677879750; bh=6Gs71kEKBpwp4cOkCn7i/3BhX3OpriQWHrFXzoQuGIQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FSPCw3NJULk/jt/cjVlSbM/UWpN77OXH++83KEP9QDgrRzRymf29QmxYGBMO9FhC5 ak9S6x4XsiW+sdYISqmlTNxlmwqaeP7POBzZFaidHztFrptUfzPnWdxlNezr7/Wa9m VgwNLJlkEiyEqU9sVNUQiVrOves3YxF5mPDMss2KaoE99PFY/MaEiReEuxsfcf/csw lr+/0l/JAn5il56b7qlL8tl1bh1AlL1xFowmC0nK5cXigEnCPrp3YhL9HYpX642M3k RpsgDUr5RoD6cT9vdwt2HlxJq3pa4/O8ntB2GNIqMsNHM51tfcYBP+66s4r0EMAFn6 wzDH/V9qd5DKQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Jakob Koschel , Sasha Levin , aaro.koskinen@iki.fi, stern@rowland.harvard.edu, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 6.2 38/64] USB: gadget: gr_udc: fix memory leak with using debugfs_lookup() Date: Fri, 3 Mar 2023 16:40:40 -0500 Message-Id: <20230303214106.1446460-38-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230303214106.1446460-1-sashal@kernel.org> References: <20230303214106.1446460-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Greg Kroah-Hartman [ Upstream commit 73f4451368663ad28daa67980c6dd11d83b303eb ] When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: Jakob Koschel Link: https://lore.kernel.org/r/20230202153235.2412790-8-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/gr_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c index 85cdc0af3bf95..09762559912d3 100644 --- a/drivers/usb/gadget/udc/gr_udc.c +++ b/drivers/usb/gadget/udc/gr_udc.c @@ -215,7 +215,7 @@ static void gr_dfs_create(struct gr_udc *dev) static void gr_dfs_delete(struct gr_udc *dev) { - debugfs_remove(debugfs_lookup(dev_name(dev->dev), usb_debug_root)); + debugfs_lookup_and_remove(dev_name(dev->dev), usb_debug_root); } #else /* !CONFIG_USB_GADGET_DEBUG_FS */ -- 2.39.2