From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F52CC83003 for ; Fri, 3 Mar 2023 21:44:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232289AbjCCVod (ORCPT ); Fri, 3 Mar 2023 16:44:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232094AbjCCVoM (ORCPT ); Fri, 3 Mar 2023 16:44:12 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E475264201; Fri, 3 Mar 2023 13:43:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D51E7B818A4; Fri, 3 Mar 2023 21:42:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C330CC4331F; Fri, 3 Mar 2023 21:42:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677879755; bh=qlL51E0/NZbjTW3c4TmV6aYGz5OpdvOQVh9xBbC5vGk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gr/T7epFoCrOcxb8q/FYLUAPb2ePLoGdSBqodAd3IuZ0XMagdXRYI2hD+oDaqARac AYEnswdnLDDzTjvtMUpMPH5H54HwcTfcYrTI3fgWXgHrMHwHmoUE5hS5QtPLizUjKj R9mShIJcMZr/JAbiWCWj5MI6QtzcRuHlcxT0t0BcqZFdtd4TYgnvePN2Rc2bfc9DVJ t1B5AY3ZoVCMJ6r4kBsKM/N6gK2h+R8s2opAOu5ef7VOMcixx1w1UiityW4Yj/t48u AtAQ8UBhiaSf+nWEa8zFmY/byjA9U3qyN93pYMXjpcZzUvdMi2NDyK3k/0g/CA3rZc 7ZFNNZPKWNbIg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Sasha Levin , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 6.2 41/64] USB: gadget: pxa25x_udc: fix memory leak with using debugfs_lookup() Date: Fri, 3 Mar 2023 16:40:43 -0500 Message-Id: <20230303214106.1446460-41-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230303214106.1446460-1-sashal@kernel.org> References: <20230303214106.1446460-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Greg Kroah-Hartman [ Upstream commit 7a038a681b7df78362d9fc7013e5395a694a9d3a ] When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Link: https://lore.kernel.org/r/20230202153235.2412790-11-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/pxa25x_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c index c593fc383481e..9e01ddf2b4170 100644 --- a/drivers/usb/gadget/udc/pxa25x_udc.c +++ b/drivers/usb/gadget/udc/pxa25x_udc.c @@ -1340,7 +1340,7 @@ DEFINE_SHOW_ATTRIBUTE(udc_debug); debugfs_create_file(dev->gadget.name, \ S_IRUGO, NULL, dev, &udc_debug_fops); \ } while (0) -#define remove_debug_files(dev) debugfs_remove(debugfs_lookup(dev->gadget.name, NULL)) +#define remove_debug_files(dev) debugfs_lookup_and_remove(dev->gadget.name, NULL) #else /* !CONFIG_USB_GADGET_DEBUG_FILES */ -- 2.39.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A249CC7EE32 for ; Fri, 3 Mar 2023 21:44:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QvjWJRPVvvHJi4drUyR9vWjDoIYE7be4GvLxF828FEQ=; b=266ElsVCqq6p0S dNQvd3WnF9oFU7T+5Zk8nTPySQ7wFHWgq4z2gF1ucEyJqL05o09wZPG6Z9QeV7J7gu68ROdWbupe4 7c5JY7ikUQuk8CGLJ2NkyMxjPTNptm34h6qjcBTcoMqEK/hhl+dy+Iwxt1gFlDyfXBR0lWe5bMiD0 jcHDuX/HR6iAEohJkt8DJouvl00n7KZYrzhdGtjS3CFDFHexxo9say4ZIGaTUhqr01fxPWOUC9iNt 3XueqU8dxHx2OSxhWNsk8gpuQvYNa2+Bwv3q9ZvRRrWAoE9oDxQGonHDZoTxM7Z2UrvNoKwWECIK3 aYu4Pt4IFxj+iByeG1Bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYDBv-007WJg-KO; Fri, 03 Mar 2023 21:43:51 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYDAp-007Vl2-JR for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 21:42:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 0F50FCE229E; Fri, 3 Mar 2023 21:42:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C330CC4331F; Fri, 3 Mar 2023 21:42:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677879755; bh=qlL51E0/NZbjTW3c4TmV6aYGz5OpdvOQVh9xBbC5vGk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gr/T7epFoCrOcxb8q/FYLUAPb2ePLoGdSBqodAd3IuZ0XMagdXRYI2hD+oDaqARac AYEnswdnLDDzTjvtMUpMPH5H54HwcTfcYrTI3fgWXgHrMHwHmoUE5hS5QtPLizUjKj R9mShIJcMZr/JAbiWCWj5MI6QtzcRuHlcxT0t0BcqZFdtd4TYgnvePN2Rc2bfc9DVJ t1B5AY3ZoVCMJ6r4kBsKM/N6gK2h+R8s2opAOu5ef7VOMcixx1w1UiityW4Yj/t48u AtAQ8UBhiaSf+nWEa8zFmY/byjA9U3qyN93pYMXjpcZzUvdMi2NDyK3k/0g/CA3rZc 7ZFNNZPKWNbIg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Sasha Levin , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 6.2 41/64] USB: gadget: pxa25x_udc: fix memory leak with using debugfs_lookup() Date: Fri, 3 Mar 2023 16:40:43 -0500 Message-Id: <20230303214106.1446460-41-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230303214106.1446460-1-sashal@kernel.org> References: <20230303214106.1446460-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_134243_953102_8A54847B X-CRM114-Status: GOOD ( 13.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Greg Kroah-Hartman [ Upstream commit 7a038a681b7df78362d9fc7013e5395a694a9d3a ] When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Link: https://lore.kernel.org/r/20230202153235.2412790-11-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/pxa25x_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c index c593fc383481e..9e01ddf2b4170 100644 --- a/drivers/usb/gadget/udc/pxa25x_udc.c +++ b/drivers/usb/gadget/udc/pxa25x_udc.c @@ -1340,7 +1340,7 @@ DEFINE_SHOW_ATTRIBUTE(udc_debug); debugfs_create_file(dev->gadget.name, \ S_IRUGO, NULL, dev, &udc_debug_fops); \ } while (0) -#define remove_debug_files(dev) debugfs_remove(debugfs_lookup(dev->gadget.name, NULL)) +#define remove_debug_files(dev) debugfs_lookup_and_remove(dev->gadget.name, NULL) #else /* !CONFIG_USB_GADGET_DEBUG_FILES */ -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel