From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCE15C7EE30 for ; Fri, 3 Mar 2023 21:50:31 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id AD0B237103 for ; Fri, 3 Mar 2023 21:50:28 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 2AFA99868A7 for ; Fri, 3 Mar 2023 21:50:28 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 68A809867AA; Fri, 3 Mar 2023 21:50:27 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-Id: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id CDA6A9867A9; Fri, 3 Mar 2023 21:49:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com Date: Fri, 3 Mar 2023 22:49:37 +0100 From: Halil Pasic To: "Michael S. Tsirkin" Cc: Cornelia Huck , Parav Pandit , virtio-dev@lists.oasis-open.org, virtio-comment@lists.oasis-open.org, shahafs@nvidia.com, Halil Pasic Message-ID: <20230303224937.62fe64b9.pasic@linux.ibm.com> In-Reply-To: <20230303023949-mutt-send-email-mst@kernel.org> References: <20230223054624.168042-1-parav@nvidia.com> <87a60z5wes.fsf@redhat.com> <20230301182207.23f995cd.pasic@linux.ibm.com> <20230301123044-mutt-send-email-mst@kernel.org> <87a60vmbub.fsf@redhat.com> <20230303023949-mutt-send-email-mst@kernel.org> Organization: IBM X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: vvDK3p2fcPUwj3AKver3us1WJ7GUAjff X-Proofpoint-ORIG-GUID: deXnK6b-0UecccU2Qjb6veXDKWRlnbQg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-03_05,2023-03-03_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 adultscore=0 impostorscore=0 priorityscore=1501 phishscore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=976 bulkscore=0 clxscore=1015 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303030183 Subject: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number On Fri, 3 Mar 2023 02:42:49 -0500 "Michael S. Tsirkin" wrote: > > > > > > And then for extra fun, in the RSS section we say "0 based index" where we > > > seem to mean "this number in the queue name, but subtract 1 in your head". > > > Why subtract 1? I guess we wanted these 5 year olds to practice math ... > > > > Heh :) > > > > Yeah, that looks like a mess... I don't think we should use a weird > > substraction scheme. I haven't looked at the RSS stuff much, would it be > > hard to fix it up? > > We can't change the ABI, I guess we can say that it's bits 1 to 15 > of the VQ number or equivalently VQ number divided > by 2 (it's always an even number for any receiveq). I don't think it would require an ABI change. We could just change the queue names. AFAIK those are not part of the ABI. I don't think it would be hard. BTW what speaks for "VQ number" over "VQ index"? Regards, Halil This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74658C64EC4 for ; Fri, 3 Mar 2023 21:50:28 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 9D0B62B147 for ; Fri, 3 Mar 2023 21:50:27 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 7C12A9867AF for ; Fri, 3 Mar 2023 21:50:27 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 6536C9867A8; Fri, 3 Mar 2023 21:50:27 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-Id: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id CDA6A9867A9; Fri, 3 Mar 2023 21:49:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com Date: Fri, 3 Mar 2023 22:49:37 +0100 From: Halil Pasic To: "Michael S. Tsirkin" Cc: Cornelia Huck , Parav Pandit , virtio-dev@lists.oasis-open.org, virtio-comment@lists.oasis-open.org, shahafs@nvidia.com, Halil Pasic Message-ID: <20230303224937.62fe64b9.pasic@linux.ibm.com> In-Reply-To: <20230303023949-mutt-send-email-mst@kernel.org> References: <20230223054624.168042-1-parav@nvidia.com> <87a60z5wes.fsf@redhat.com> <20230301182207.23f995cd.pasic@linux.ibm.com> <20230301123044-mutt-send-email-mst@kernel.org> <87a60vmbub.fsf@redhat.com> <20230303023949-mutt-send-email-mst@kernel.org> Organization: IBM X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: vvDK3p2fcPUwj3AKver3us1WJ7GUAjff X-Proofpoint-ORIG-GUID: deXnK6b-0UecccU2Qjb6veXDKWRlnbQg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-03_05,2023-03-03_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 adultscore=0 impostorscore=0 priorityscore=1501 phishscore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=976 bulkscore=0 clxscore=1015 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303030183 Subject: Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number On Fri, 3 Mar 2023 02:42:49 -0500 "Michael S. Tsirkin" wrote: > > > > > > And then for extra fun, in the RSS section we say "0 based index" where we > > > seem to mean "this number in the queue name, but subtract 1 in your head". > > > Why subtract 1? I guess we wanted these 5 year olds to practice math ... > > > > Heh :) > > > > Yeah, that looks like a mess... I don't think we should use a weird > > substraction scheme. I haven't looked at the RSS stuff much, would it be > > hard to fix it up? > > We can't change the ABI, I guess we can say that it's bits 1 to 15 > of the VQ number or equivalently VQ number divided > by 2 (it's always an even number for any receiveq). I don't think it would require an ABI change. We could just change the queue names. AFAIK those are not part of the ABI. I don't think it would be hard. BTW what speaks for "VQ number" over "VQ index"? Regards, Halil --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org