From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1EEDC61DA3 for ; Sat, 4 Mar 2023 02:02:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF5B06B0072; Fri, 3 Mar 2023 21:02:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA5F76B0073; Fri, 3 Mar 2023 21:02:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6DC16B0074; Fri, 3 Mar 2023 21:02:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 995F56B0072 for ; Fri, 3 Mar 2023 21:02:01 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5E51712134C for ; Sat, 4 Mar 2023 02:02:01 +0000 (UTC) X-FDA: 80529565242.10.B50AF79 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf14.hostedemail.com (Postfix) with ESMTP id 9352610000D for ; Sat, 4 Mar 2023 02:01:58 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=h+yV8yvo; spf=pass (imf14.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677895318; a=rsa-sha256; cv=none; b=p1In7k/MbZriCDN8irUbqvdYj86gHEaUABnZn6SKPnDDt3rnIIDGov8b63PkpOIXD4r4f/ bc15kR0ee5mOocP4mMzkkDmPYPdfYHPzvcsUzpnUl/8uvpZ7uCqK1Ubi2BV961ZWydNCX+ wTBZ+YjdC5s/GSKD7GMaZWFhaDp/ZzY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=h+yV8yvo; spf=pass (imf14.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677895318; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+G4ef65CSgKpxodjySBoOq5VwIhCSm6EqLMcA3UHuRg=; b=ljqMPMK5N0L02Kl13pqnf353h1mvgPU4H0sG1zTDo7aDHTG/bTzrXxDm0UjbDBN9nMFeQp ffEZrrs40gi7Q7pBuXOIWPcw0gBHQnPd/JKD6ZJFw5oULf2I/8bvB7VkZmxDuJnoX0izux 4YJ/BIVXVxumwVOYgibEEGP+I0/CPdY= Received: by mail-pj1-f44.google.com with SMTP id ce8-20020a17090aff0800b0023a61cff2c6so3451183pjb.0 for ; Fri, 03 Mar 2023 18:01:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+G4ef65CSgKpxodjySBoOq5VwIhCSm6EqLMcA3UHuRg=; b=h+yV8yvoyJXkMqyOgspcWKCRZNDgusSMt1YNnrOA+zRsFudDnbHltOBoCMZKBO5aJd J610cdtZjvhAb6Oj3u/diuevcD/P7pqcglfrlTlL4JWp0siYEH/4ayEA0xWzXkUfSX39 8AxPS4aD0VE1CdazIiEZy7T72vWTm+ge93Lyo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+G4ef65CSgKpxodjySBoOq5VwIhCSm6EqLMcA3UHuRg=; b=Wkrb57eizg0sKr2QJXZNneZ40ajogRny+PNDUk0aFiihhXySMDyzs6Jm1nJAFxtL4Y HICgJIroeDDIay/gDqx3CJiBZIE0NzsFyc2/fBHACHdlJNYGAhWeAEvX1TMBMb/5y+5q +PtozX6DTwAuqqdnQOvp5+sp/WtH5Y+A9ubRS/VlwdgoATz11yb50vCwPVAtYwDR9Z8q CqGRrQJUmVxMg7VM3Y8WltShATWXp633y8KoAsy2THMJAk32g9k5UlqeRaSCcsUC/v54 leoyC3MJUzcmRkt7URYsDzRQOuxo/kUo4yKRUU2CWNn5+GU1LbgEMjMN2JO/VBUZOwzI 8M+w== X-Gm-Message-State: AO0yUKX4aLYSU1467tqJeh8QWrIYyD7xUJ/J1U574YdSzWbMwK2JDT/l CqAkakeGi/jFaVS5umFG9xqzbA== X-Google-Smtp-Source: AK7set8CJ8UOVdkGOdOjj8r2Kp6R1M9AS8cfkNqVfBkDuY5AQd5bHWb0G1Q5hw+hWhqThqn0XdIMig== X-Received: by 2002:a17:90b:1e0f:b0:237:c209:5b14 with SMTP id pg15-20020a17090b1e0f00b00237c2095b14mr3574252pjb.22.1677895317278; Fri, 03 Mar 2023 18:01:57 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id f22-20020a17090ac29600b002372107fc3fsm2175363pjt.0.2023.03.03.18.01.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 18:01:56 -0800 (PST) Date: Sat, 4 Mar 2023 11:01:52 +0900 From: Sergey Senozhatsky To: Andrew Morton , Yosry Ahmed Cc: Sergey Senozhatsky , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv3 2/4] zsmalloc: fine-grained inuse ratio based fullness grouping Message-ID: <20230304020152.GB5231@google.com> References: <20230303073130.1950714-1-senozhatsky@chromium.org> <20230303073130.1950714-3-senozhatsky@chromium.org> <20230303152833.24d7a42102bd712e09f95cd5@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230303152833.24d7a42102bd712e09f95cd5@linux-foundation.org> X-Rspam-User: X-Rspamd-Queue-Id: 9352610000D X-Rspamd-Server: rspam01 X-Stat-Signature: ihi4ghfymja9ckiib5k5594sxq81mqrc X-HE-Tag: 1677895318-332237 X-HE-Meta: U2FsdGVkX18BzIA00HN7AEYJiVU0wJSf4Mbo9YzRTPuuRa3JD3/UcvuaU2IEECMEP0wPFUvfBmOH9Cw/Q4p1qnip2qDLb2jGOz5jltaUVz903ZSncJhHZrkm3qYxGNozHfHdYWvp3bBQvgr22q2pFEZFHcbPQZq3U/rOXuKz2zk2EihKnj6e4ClbWRFwSKmb+BNBw2uYgl/4+z2KKPCsy1dEB9aGgqdXOmECReLKp3wiWlaw7MCd01HaDlio7eZFAeEsXm7nz6rUtlfGi3tXsP0oeObdrQI/tWTYPPgLXItnVIykyp77MYRz7494DLrvd6UIJ0ASIsF81m5MlaJFnC8pPPbac2tRjQCW8kQWiBcxPJF2/O5/tDwqS83i34AMB8TNvNlyWZo4W3ccN96+q/e1hoZbpAQS4GPmRwmoUFAOWQRPX0taVS/+8b7tx5BHEvBFFwlqcW4RxrfYj4c+fRCUGHK88sy/2+/niNKJHibW8km1Epur8qHfuaCkJ8x+2ZOBfs6l5/cFyd9egFB6As/MQRolBcWu1Bp7oXOwRGBphVPzaPqI0C/04OOSdfIJbV9oyN/JXOoQyIiLGVKAo3i5Xus241Eu4anb2WAQarkOPq/A0tifQ/4BrCc+nGXxXu8TbVLYaZk4nz+wiDYGwJVOvAqG5swo0sdNeJJ47peQlIveHsqQxroqBPxBfCPuB2wQvAchJoVFvBl1srlpYJdvhmbL9uqlNBaUUfNxs/pisbh32NB9qwka/TPUGtmbqWEYlgAX4waNaSNlf49pYEL6ekwSkyUsw9V45eeVrQtaAJCp4v3b5tSmHcRzpw5eFSrDuJVI0Bb8jTvmWToMS9ARLqVcxBXYb07IdthakJlIwZLdb0w8c/V4qZoK43Q/dFuMonLoIhV0W0K+QMUscU5+yNSiG/mYXcGWTQadBuN/yCWwlzQWP2qZOVbiAIfuTMxp+hX0zZ/2IjwekRR 3cMGR3ie C1VWYL2inLIHUIcLsc/H9ByM8ahDVK978ZoCd7ClibrGArWaRAUDuWCzslSJ+ugdcstdGfP9UmP42R6qfmgXGEWRCyNH5U0Jjw+Je5Qa7xxM4oaKFCdb6Cvde7k74UtKB63U40yBdw5W9XnSsrKT9DV2pa6PPR2VJ/r4wWdjO/lFoROK5OgT8dgN0KXUi2Vc2UhfGamYTjffTGrCFNFT5zN7mxzQcNskhoXUZ1Gmj/FTHbRysL0klX+LzcLWQLLFd7HRlKM8tFOX6yuzW0Wp7Ge75lVlaSC2Txh7rLzR43NAUasvo2OZU5RQF2g9O8wjut6NRs2z3+a5LkG+SueoNGBAX1wQnLrNl6Uiwt+KLsivNWsL2Sr14MhqXhD05XSpqOsggF624od3x0sFQJuFuwJPFYRMtQR9Nc8Wz+gZtypIGQA6UyVUoYC5muiGSHnUxK1epJdnz4JVVa0ZYZsZv5npFqG/r4soLZsT68tXuEYtax73OJcBiSPYGHwiCewEbY4BJCEgot9VMux/DZs/PG7uAOJ/FmnZDC5vBQK80mtRNTwkZrAqaSukZomjqwJnA9dQRDtJHLIZ8QhQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000027, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/03/03 15:28), Andrew Morton wrote: > Date: Fri, 3 Mar 2023 15:28:33 -0800 > From: Andrew Morton > To: Yosry Ahmed > Cc: Sergey Senozhatsky , Minchan Kim > , linux-kernel@vger.kernel.org, linux-mm@kvack.org > Subject: Re: [PATCHv3 2/4] zsmalloc: fine-grained inuse ratio based > fullness grouping > Message-Id: <20230303152833.24d7a42102bd712e09f95cd5@linux-foundation.org> > X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) > > On Fri, 3 Mar 2023 08:58:55 -0800 Yosry Ahmed wrote: > > > > > + for (fg = ZS_INUSE_RATIO_70; fg <= ZS_INUSE_RATIO_99; fg++) > > > > + class_almost_full = zs_stat_get(class, fg); > > > > + for (fg = ZS_INUSE_RATIO_10; fg < ZS_INUSE_RATIO_70; fg++) > > > > + class_almost_empty = zs_stat_get(class, fg); > > > > > > Aren't these supposed to be += ? Good catch Yosry! Thanks for taking a look. > I'll fix that up anyway, to avoid a bisection hole. And in case [patch 4/4] > gets dropped from the series or is later reverted or whatever. Thanks Andrew, should I just send out a v4 with 3/4 and 4/4 fixed up?