From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B01C6C64EC4 for ; Sat, 4 Mar 2023 19:06:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 437DC415FC; Sat, 4 Mar 2023 19:06:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 437DC415FC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1677956811; bh=3hx5RukyXhymUZNLHjIlY9nbE147YC3nljWx3yKEj4U=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=vKOv/8rsuD58lzWRGwws6KiwuZYw0fY9J6AZaSURS2WJ/mXqvG0uAg6GqG7x5Rs+n u3e/K/wszEkwyWWETttaTXsERlGZwW+asBktrBpVyoKqSg5eILeknYheuvnnnn1+Zy mtE4sKnQ9bZgwwNkzIVF+GFJoedbQbxFMQZd0kclOH5EkiGnzB9n45rYvmugYUGsB7 E1S1yCQFyHbPA4+ZMvmgn0FEg5LXxBLUeujUMgxeJw8J0F3XFkoLtg4urD09Ina7RZ VydklNMYlIaSg2GEW7l1shh+KuM/NBYaydBeuQ/YF+tB+2NMED3ApcYbXql4rOiC+L aTXgL4E2ZokOw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K8T0RQgNRQa5; Sat, 4 Mar 2023 19:06:50 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 1B5EA415FF; Sat, 4 Mar 2023 19:06:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1B5EA415FF Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 384961BF337 for ; Sat, 4 Mar 2023 19:06:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0D08F81EAF for ; Sat, 4 Mar 2023 19:06:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0D08F81EAF X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ndnRcVPqoFtY for ; Sat, 4 Mar 2023 19:06:47 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1D7FB81EAD Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp1.osuosl.org (Postfix) with ESMTPS id 1D7FB81EAD for ; Sat, 4 Mar 2023 19:06:47 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CC54FB80861; Sat, 4 Mar 2023 19:06:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B347C433D2; Sat, 4 Mar 2023 19:06:42 +0000 (UTC) Date: Sat, 4 Mar 2023 11:06:41 -0800 From: Jakub Kicinski To: Vincenzo Palazzo Message-ID: <20230304110641.6467996b@kernel.org> In-Reply-To: <20230304115626.215026-1-vincenzopalazzodev@gmail.com> References: <20230304115626.215026-1-vincenzopalazzodev@gmail.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677956802; bh=llPqKaSk8yrwRDfiaCFBbc4Rc64fzYfNkvIE/ve5xro=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CuynGzRaIPdUnKhPurzae1GC70tRn7poznmyzlKkq2GwcBTieSBASVphWX5zAvxW2 bd4eqRcEMJ4AQnxp1jqFIxuoHJgYAEoOSVQCxQnnxqEkn3bXFlLRw+wV+BkYXU1Aup fQxmFuoTjMqvbPFPkd2jJt+pOPOR/6uCTFivTmDAtE2xXRUmX4OZUd0c0oaI8lc+Jb E51W9h5kd1QX4kX4bOpwgXkFS13iZ0NS/1IhZNM6FBVjemIOCY5/0Dt63HaaVIOkUF YCPlnPVQwraH0CYW/jl+/IcQu9PzD+0yg56xbRLH83F5qqRAQAUUj6K4mYabsM7Wvk RyVvAvGYjjHNQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=CuynGzRa Subject: Re: [Intel-wired-lan] [PATCH v3] netdevice: use ifmap instead of plain fields X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, jesse.brandeburg@intel.com, intel-wired-lan@lists.osuosl.org, davem@davemloft.net, khc@pm.waw.pl Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sat, 4 Mar 2023 12:56:26 +0100 Vincenzo Palazzo wrote: > clean the code by using the ifmap instead of plain fields, > and avoid code duplication. > > Reported-by: kernel test robot > Link: https://lore.kernel.org/oe-kbuild-all/202303041847.nRrrz1v9-lkp@intel.com/ > Signed-off-by: Vincenzo Palazzo Please don't, as already explained it's not worth the code churn. Nacked-by: Jakub Kicinski _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71282C64EC4 for ; Sat, 4 Mar 2023 19:06:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229512AbjCDTGp (ORCPT ); Sat, 4 Mar 2023 14:06:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjCDTGo (ORCPT ); Sat, 4 Mar 2023 14:06:44 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CBE51ACEB for ; Sat, 4 Mar 2023 11:06:43 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 174FC60687 for ; Sat, 4 Mar 2023 19:06:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B347C433D2; Sat, 4 Mar 2023 19:06:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677956802; bh=llPqKaSk8yrwRDfiaCFBbc4Rc64fzYfNkvIE/ve5xro=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CuynGzRaIPdUnKhPurzae1GC70tRn7poznmyzlKkq2GwcBTieSBASVphWX5zAvxW2 bd4eqRcEMJ4AQnxp1jqFIxuoHJgYAEoOSVQCxQnnxqEkn3bXFlLRw+wV+BkYXU1Aup fQxmFuoTjMqvbPFPkd2jJt+pOPOR/6uCTFivTmDAtE2xXRUmX4OZUd0c0oaI8lc+Jb E51W9h5kd1QX4kX4bOpwgXkFS13iZ0NS/1IhZNM6FBVjemIOCY5/0Dt63HaaVIOkUF YCPlnPVQwraH0CYW/jl+/IcQu9PzD+0yg56xbRLH83F5qqRAQAUUj6K4mYabsM7Wvk RyVvAvGYjjHNQ== Date: Sat, 4 Mar 2023 11:06:41 -0800 From: Jakub Kicinski To: Vincenzo Palazzo Cc: netdev@vger.kernel.org, davem@davemloft.net, intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com, khc@pm.waw.pl, kernel test robot Subject: Re: [PATCH v3] netdevice: use ifmap instead of plain fields Message-ID: <20230304110641.6467996b@kernel.org> In-Reply-To: <20230304115626.215026-1-vincenzopalazzodev@gmail.com> References: <20230304115626.215026-1-vincenzopalazzodev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 4 Mar 2023 12:56:26 +0100 Vincenzo Palazzo wrote: > clean the code by using the ifmap instead of plain fields, > and avoid code duplication. > > Reported-by: kernel test robot > Link: https://lore.kernel.org/oe-kbuild-all/202303041847.nRrrz1v9-lkp@intel.com/ > Signed-off-by: Vincenzo Palazzo Please don't, as already explained it's not worth the code churn. Nacked-by: Jakub Kicinski