From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>,
Elena Reshetova <elena.reshetova@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Extend Wa_14017073508 in suspend/resume flow
Date: Mon, 6 Mar 2023 06:37:30 +0800 [thread overview]
Message-ID: <202303060604.JmbyHTX7-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230304161749.1420224-1-badal.nilawar@intel.com>
References: <20230304161749.1420224-1-badal.nilawar@intel.com>
TO: Badal Nilawar <badal.nilawar@intel.com>
TO: intel-gfx@lists.freedesktop.org
CC: rodrigo.vivi@intel.com
Hi Badal,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip]
url: https://github.com/intel-lab-lkp/linux/commits/Badal-Nilawar/drm-i915-mtl-Extend-Wa_14017073508-in-suspend-resume-flow/20230305-001604
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link: https://lore.kernel.org/r/20230304161749.1420224-1-badal.nilawar%40intel.com
patch subject: [Intel-gfx] [PATCH] drm/i915/mtl: Extend Wa_14017073508 in suspend/resume flow
:::::: branch date: 30 hours ago
:::::: commit date: 30 hours ago
config: x86_64-randconfig-c002 (https://download.01.org/0day-ci/archive/20230306/202303060604.JmbyHTX7-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Link: https://lore.kernel.org/r/202303060604.JmbyHTX7-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/gt/intel_gt_pm.c:49:50-51: atomic_add_unless
vim +49 drivers/gpu/drm/i915/gt/intel_gt_pm.c
8f70f1ec587da0 Badal Nilawar 2022-11-04 42
e49da7f17006c4 Badal Nilawar 2023-03-04 43 void mtl_media_idle(struct intel_gt *gt)
8f70f1ec587da0 Badal Nilawar 2022-11-04 44 {
8f70f1ec587da0 Badal Nilawar 2022-11-04 45 /* Wa_14017073508: mtl */
e49da7f17006c4 Badal Nilawar 2023-03-04 46 if (gt && IS_MTL_GRAPHICS_STEP(gt->i915, P, STEP_A0, STEP_B0) &&
e49da7f17006c4 Badal Nilawar 2023-03-04 47 gt->type == GT_MEDIA) {
e49da7f17006c4 Badal Nilawar 2023-03-04 48 WARN_ON(atomic_read(>->media_wakeref) <= 0);
e49da7f17006c4 Badal Nilawar 2023-03-04 @49 if (!atomic_add_unless(>->media_wakeref, -1, 1)) {
e49da7f17006c4 Badal Nilawar 2023-03-04 50 drm_err(>->i915->drm, "Media idle\n");
8f70f1ec587da0 Badal Nilawar 2022-11-04 51 snb_pcode_write_p(gt->uncore, PCODE_MBOX_GT_STATE,
8f70f1ec587da0 Badal Nilawar 2022-11-04 52 PCODE_MBOX_GT_STATE_MEDIA_NOT_BUSY,
8f70f1ec587da0 Badal Nilawar 2022-11-04 53 PCODE_MBOX_GT_STATE_DOMAIN_MEDIA, 0);
e49da7f17006c4 Badal Nilawar 2023-03-04 54 atomic_dec(>->media_wakeref);
e49da7f17006c4 Badal Nilawar 2023-03-04 55 }
e49da7f17006c4 Badal Nilawar 2023-03-04 56 }
8f70f1ec587da0 Badal Nilawar 2022-11-04 57 }
8f70f1ec587da0 Badal Nilawar 2022-11-04 58
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next reply other threads:[~2023-03-05 22:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-05 22:37 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-04 16:17 [Intel-gfx] [PATCH] drm/i915/mtl: Extend Wa_14017073508 in suspend/resume flow Badal Nilawar
2023-03-06 8:33 ` Gupta, Anshuman
2023-03-06 20:20 ` Rodrigo Vivi
2023-03-07 13:44 ` Nilawar, Badal
2023-03-06 13:34 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202303060604.JmbyHTX7-lkp@intel.com \
--to=lkp@intel.com \
--cc=elena.reshetova@intel.com \
--cc=julia.lawall@inria.fr \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.