From: Jakub Kicinski <kuba@kernel.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
rbradford@rivosinc.com, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] virtio-net: Fix probe of virtio-net on kvmtool
Date: Mon, 6 Mar 2023 10:12:34 -0800 [thread overview]
Message-ID: <20230306101234.08da367d@kernel.org> (raw)
In-Reply-To: <20230305045249-mutt-send-email-mst@kernel.org>
On Sun, 5 Mar 2023 04:53:58 -0500 Michael S. Tsirkin wrote:
> > > yes what we do work according to code. So the documentation is wrong then?
> >
> > It's definitely incomplete but which part are you saying is wrong?
>
> So it says:
> 2. netdev->features set contains features which are currently enabled
> for a device.
>
> ok so far.
> But this part:
>
> This should be changed only by network core or in
> error paths of ndo_set_features callback.
>
> seems to say virtio should not touch netdev->features, no?
Oh, I see, yes. We should add a mention of ndo_fix_features there,
and perhaps "see Part II for more information"?.
The sentence reads like someone was trying to make sure drivers don't
silently change features without calling netdev_update_features().
prev parent reply other threads:[~2023-03-06 18:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 13:59 [PATCH v3] virtio-net: Fix probe of virtio-net on kvmtool Rob Bradford
2023-03-01 13:59 ` Rob Bradford via B4 Relay
2023-03-01 14:44 ` Michael S. Tsirkin
2023-03-01 14:44 ` Michael S. Tsirkin
2023-03-02 8:10 ` Jason Wang
2023-03-02 8:10 ` Jason Wang
2023-03-02 9:45 ` Paolo Abeni
2023-03-02 9:45 ` Paolo Abeni
2023-03-02 9:48 ` Michael S. Tsirkin
2023-03-02 9:48 ` Michael S. Tsirkin
2023-03-04 0:46 ` Jakub Kicinski
2023-03-05 9:53 ` Michael S. Tsirkin
2023-03-05 9:53 ` Michael S. Tsirkin
2023-03-06 8:44 ` Xuan Zhuo
2023-03-06 8:44 ` Xuan Zhuo
2023-03-06 18:12 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306101234.08da367d@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rbradford@rivosinc.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.