From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF03EC61DA4 for ; Mon, 6 Mar 2023 14:34:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A61CA85894; Mon, 6 Mar 2023 15:34:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="I690fu4P"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 77BC7858BE; Mon, 6 Mar 2023 15:34:31 +0100 (CET) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5A77085650 for ; Mon, 6 Mar 2023 15:34:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id c3so10635464qtc.8 for ; Mon, 06 Mar 2023 06:34:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1678113266; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vbwQ/PPlBYfY7++xVmhLYXP4GchIh1+i7Dy+50Z7rAg=; b=I690fu4P6aQjye+C1cIeSmQNe6UPAcHLrq3Zqwq1D0mjRhGbwm0De+wk2D5adTOMbw keQxYLBOqyZZujLSjJdZ4SmUy98qLVJGbOAsGsM85JpC6hoNN24PclvIxNPL2eaKBM5V 0wpMX/zz8s7cj/V042qGXWkUYcq/KLl0S1Ee0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678113266; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vbwQ/PPlBYfY7++xVmhLYXP4GchIh1+i7Dy+50Z7rAg=; b=ZUYXbOSEKfZQDDIe8LDJ/GuvqIWzfyUuY2KTbXT2BmobxWPQ/cCLagl/2EWHh8eq7K 9Nnfd26i5QV1ZSTk61S98aVEOuFkUvBGi4SWteAjUvXcDFx4HsZW08D/LGGaEfNXLG9M WIxMXjzJfsvDlQc3GgIiaJAqz5esY8bqywMhz07wLxNrsJ/bX+3mMP40EJPknLI27Jny g5scUuiIKdV08ULdRr9z7kIEYeKh5wMbtJ7I18QJ64Jm8V3po9EHAfF4rjlBvyweCraG GQqyH3zT8jvtVnMbmJvoOQQJYLSI+zis/TaTn6T9krqbiTdJsAirHcfctuCYtJkZxuZT UsKQ== X-Gm-Message-State: AO0yUKUCoUpwk5YA0aGjyEVbCI96V4taAhym/i9vcbTDgTcdxHQi7Jgd FpxYcM1UOLdZXASaU/hkbRwY9Q== X-Google-Smtp-Source: AK7set9R7X20ZD0zeT0kedfkB2CGtbIV2DmTrC73be3b9FfJiylswvLVewNnNNesZDt9KNmj5YQfJQ== X-Received: by 2002:a05:622a:5cf:b0:3bf:de3a:e717 with SMTP id d15-20020a05622a05cf00b003bfde3ae717mr18822780qtb.39.1678113265966; Mon, 06 Mar 2023 06:34:25 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0000-0000-0000-036b.res6.spectrum.com. [2603:6081:7b00:6400::36b]) by smtp.gmail.com with ESMTPSA id d8-20020a05622a05c800b003bfb845497dsm7741425qtb.97.2023.03.06.06.34.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 06:34:25 -0800 (PST) Date: Mon, 6 Mar 2023 09:34:23 -0500 From: Tom Rini To: Heinrich Schuchardt Cc: Jaehoon Chung , Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH 1/1] api: move API related config options into submenu Message-ID: <20230306143423.GX968799@bill-the-cat> References: <20230303223122.60900-1-heinrich.schuchardt@canonical.com> <20230304153215.GW968799@bill-the-cat> <6b822071-a1ae-b315-a484-a19fb1844b11@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wmyWCLV7+jeG2TvJ" Content-Disposition: inline In-Reply-To: <6b822071-a1ae-b315-a484-a19fb1844b11@canonical.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --wmyWCLV7+jeG2TvJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 06, 2023 at 11:18:17AM +0100, Heinrich Schuchardt wrote: > On 3/4/23 16:32, Tom Rini wrote: > > On Fri, Mar 03, 2023 at 11:31:22PM +0100, Heinrich Schuchardt wrote: > >=20 > > > Kconfig settings that are related to the API for standalone applicati= ons > > > should be in the API sub-menu and not on the top level. > > >=20 > > > CONFIG_STANDALONE_LOAD_ADDR is only relevant if standalone example > > > applications are built. > > >=20 > > > Signed-off-by: Heinrich Schuchardt > > > --- > > > Kconfig | 8 -------- > > > api/Kconfig | 11 ++++++++++- > > > 2 files changed, 10 insertions(+), 9 deletions(-) > >=20 > > Did you put this through CI? It's possible that some envs don't do > > "loadaddr=3DCONFIG_STANDALONE_LOAD_ADDR" and not enable API stuff anymo= re, > > but I think that's why I did what I did when migrating. > >=20 >=20 > Hello Tom, >=20 > we should keep the main Kconfig menu clean of detail settings. I don't th= in > that there is an issue with the current patch. Yes, there's many ways Kconfig needs to be cleaned up, especially now that the migration of symbols from the board.h files is done. Some of the oddities were a result of symbol misuse/abuse, which can be fixed now. > STANDALONE_LOAD_ADDR is not used for loadaddr: >=20 > $ git grep -n STANDALONE_LOAD_ADDR > (based on origin/master) >=20 > api/Kconfig:15 > config STANDALONE_LOAD_ADDR >=20 > config.mk:79 > export CONFIG_STANDALONE_LOAD_ADDR >=20 > configs/display5_defconfig:33 > CONFIG_STANDALONE_LOAD_ADDR=3D0x10001000 >=20 > configs/display5_factory_defconfig:30 > CONFIG_STANDALONE_LOAD_ADDR=3D0x10001000 >=20 > configs/microchip_mpfs_icicle_defconfig:15 > CONFIG_STANDALONE_LOAD_ADDR=3D0x80200000 >=20 > configs/qemu-riscv32_defconfig:12 > CONFIG_STANDALONE_LOAD_ADDR=3D0x80200000 >=20 > configs/qemu-riscv32_smode_defconfig:13 > CONFIG_STANDALONE_LOAD_ADDR=3D0x80200000 >=20 > configs/qemu-riscv32_spl_defconfig:15 > CONFIG_STANDALONE_LOAD_ADDR=3D0x80200000 >=20 > configs/qemu-riscv64_defconfig:12 > CONFIG_STANDALONE_LOAD_ADDR=3D0x80200000 >=20 > configs/qemu-riscv64_smode_defconfig:13 > CONFIG_STANDALONE_LOAD_ADDR=3D0x80200000 >=20 > configs/qemu-riscv64_spl_defconfig:14 > CONFIG_STANDALONE_LOAD_ADDR=3D0x80200000 >=20 > configs/sifive_unleashed_defconfig:21 > CONFIG_STANDALONE_LOAD_ADDR=3D0x80200000 >=20 > configs/sifive_unmatched_defconfig:24 > CONFIG_STANDALONE_LOAD_ADDR=3D0x80200000 >=20 > configs/xtfpga_defconfig:12 > CONFIG_STANDALONE_LOAD_ADDR=3D0x00800000 >=20 > examples/standalone/Makefile:45 > LDFLAGS_STANDALONE +=3D -Ttext $(CONFIG_STANDALONE_LOAD_ADDR) >=20 > tools/patman/test_checkpatch.py:208 > CONFIG_STANDALONE_LOAD_ADDR >=20 > With the patch applied > https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/15474 > showed no issues. Thanks for checking. In general, a CI run for making symbols less visible will make life easier on me when merging. --=20 Tom --wmyWCLV7+jeG2TvJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQF+ecACgkQFHw5/5Y0 tyz9bQv9E+VCGdgvivXUZ8ZIhJmbryO8m2a4LObRwX46pRKATFgLw65eW863Mwrv 7gst/GwF59cI5anKXg50L8kLZhl8PXr+aj4cu1XdYP6AlBkmFxtNtuS7txYHrT8L flK5BhB8/0Lms1ZZh77udpIu9JM7ZP24HAJBsXBcSskBx4xkLAsyvrWhoqib3Bdl lhIYW0WVpgQENDfTtL3j0c0sGQzH2GDaCSz18RxNGY1BKchn0IrzLeiGEiYibEz7 k3mdaYLp/Up78ru8If4dNJ8s3oUlsxURxnAHkX8Ss0DIO7+znX/HWzFY0bxapuw8 if8gTiuBg8wqmTsoDuR3Fdaelq/VfaQMCNi6EISx64TRwEWfwLcsYZ9zzJzrpz3m o6J+DHEhC87LZioxAld/saN/fIjOPCDUETSBWmvJuUTE2hpGLtNWq5QlWcYZVJj7 YV/kLVti7E5aPC3g9G7ZmLXcU6yl8174gZwRhJ9YVimIFv7897N48phcC122cnEW 4OsTQ+wQ =mOS/ -----END PGP SIGNATURE----- --wmyWCLV7+jeG2TvJ--