From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: mhi@lists.linux.dev
Cc: quic_jhugo@quicinc.com, quic_vpernami@quicinc.com
Subject: Re: [PATCH] bus: mhi: host: Remove mhi_poll() API
Date: Tue, 7 Mar 2023 22:05:33 +0530 [thread overview]
Message-ID: <20230307163533.GF5599@thinkpad> (raw)
In-Reply-To: <20230224120147.19851-1-manivannan.sadhasivam@linaro.org>
On Fri, Feb 24, 2023 at 05:31:47PM +0530, Manivannan Sadhasivam wrote:
> mhi_poll() API is not used within the MHI stack and also not by any client
> drivers in mainline. So let's remove it until any consumer is available.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Applied to mhi-next!
Thanks,
Mani
> ---
> drivers/bus/mhi/host/main.c | 15 ---------------
> include/linux/mhi.h | 7 -------
> 2 files changed, 22 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c
> index df0fbfee7b78..4fa0969472fc 100644
> --- a/drivers/bus/mhi/host/main.c
> +++ b/drivers/bus/mhi/host/main.c
> @@ -1679,18 +1679,3 @@ void mhi_unprepare_from_transfer(struct mhi_device *mhi_dev)
> }
> }
> EXPORT_SYMBOL_GPL(mhi_unprepare_from_transfer);
> -
> -int mhi_poll(struct mhi_device *mhi_dev, u32 budget)
> -{
> - struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl;
> - struct mhi_chan *mhi_chan = mhi_dev->dl_chan;
> - struct mhi_event *mhi_event = &mhi_cntrl->mhi_event[mhi_chan->er_index];
> - int ret;
> -
> - spin_lock_bh(&mhi_event->lock);
> - ret = mhi_event->process_event(mhi_cntrl, mhi_event, budget);
> - spin_unlock_bh(&mhi_event->lock);
> -
> - return ret;
> -}
> -EXPORT_SYMBOL_GPL(mhi_poll);
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index a5441ad33c74..f6de4b6ecfc7 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -765,13 +765,6 @@ int mhi_prepare_for_transfer_autoqueue(struct mhi_device *mhi_dev);
> */
> void mhi_unprepare_from_transfer(struct mhi_device *mhi_dev);
>
> -/**
> - * mhi_poll - Poll for any available data in DL direction
> - * @mhi_dev: Device associated with the channels
> - * @budget: # of events to process
> - */
> -int mhi_poll(struct mhi_device *mhi_dev, u32 budget);
> -
> /**
> * mhi_queue_dma - Send or receive DMA mapped buffers from client device
> * over MHI channel
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2023-03-07 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 12:01 [PATCH] bus: mhi: host: Remove mhi_poll() API Manivannan Sadhasivam
2023-02-24 14:43 ` Jeffrey Hugo
2023-03-07 16:35 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307163533.GF5599@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=quic_jhugo@quicinc.com \
--cc=quic_vpernami@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.