From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF5E2BA32 for ; Tue, 7 Mar 2023 17:07:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C15CC433D2; Tue, 7 Mar 2023 17:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678208826; bh=45/tDTuMGKi+l+jFTu+HeWQLDTp7g0ZN66LfUc6ziDw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m4T8qW3HB3M4ryzWckAe/o/r+MEEknoBE5Lfrhe3w2P6nhNlSPr0baC+63s5WioEX u9vZwOInLaD/ib4SU99f/lFEHGq1dnksr4XR3M1Hs2Ays+wf8yCp7/+lnKlA2rjhRd DaXoweimqJSgELVmpWl1KuRRDGq7UOmiQ/X7u7LI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Matt Fagnani , Vasant Hegde , Suravee Suthikulpanit , Joerg Roedel , "Limonciello, Mario" Subject: [PATCH 6.2 0003/1001] iommu/amd: Fix error handling for pdev_pri_ats_enable() Date: Tue, 7 Mar 2023 17:46:15 +0100 Message-Id: <20230307170022.255799690@linuxfoundation.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230307170022.094103862@linuxfoundation.org> References: <20230307170022.094103862@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Vasant Hegde commit 080920e52148b4fbbf9360d5345fdcd7846e4841 upstream. Current code throws kernel warning if it fails to enable pasid/pri [1]. Do not call pci_disable_[pasid/pri] if pci_enable_[pasid/pri] failed. [1] https://lore.kernel.org/linux-iommu/15d0f9ff-2a56-b3e9-5b45-e6b23300ae3b@leemhuis.info/ Reported-by: Matt Fagnani Signed-off-by: Vasant Hegde Reviewed-by: Suravee Suthikulpanit Link: https://lore.kernel.org/r/20230111121503.5931-1-vasant.hegde@amd.com Signed-off-by: Joerg Roedel Cc: "Limonciello, Mario" Signed-off-by: Greg Kroah-Hartman --- drivers/iommu/amd/iommu.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) --- a/drivers/iommu/amd/iommu.c +++ b/drivers/iommu/amd/iommu.c @@ -1702,27 +1702,29 @@ static int pdev_pri_ats_enable(struct pc /* Only allow access to user-accessible pages */ ret = pci_enable_pasid(pdev, 0); if (ret) - goto out_err; + return ret; /* First reset the PRI state of the device */ ret = pci_reset_pri(pdev); if (ret) - goto out_err; + goto out_err_pasid; /* Enable PRI */ /* FIXME: Hardcode number of outstanding requests for now */ ret = pci_enable_pri(pdev, 32); if (ret) - goto out_err; + goto out_err_pasid; ret = pci_enable_ats(pdev, PAGE_SHIFT); if (ret) - goto out_err; + goto out_err_pri; return 0; -out_err: +out_err_pri: pci_disable_pri(pdev); + +out_err_pasid: pci_disable_pasid(pdev); return ret;