From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71C46BA45 for ; Tue, 7 Mar 2023 17:56:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEC53C433EF; Tue, 7 Mar 2023 17:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678211792; bh=Ch2GagY3l/hGH3hLwxa3GxLjMtkCKVzwc3FN0Tlq1Mo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iD/LJdSp1G6d8lwBy8TGrhfzIZD/7nJF6cBWymWAzWuo6+E2ih/d201na3L6qkiBm vGoi2NEbvR12WoJ1zGAiRT7zosJqzY8QiayuRLpM8NGqNh4tfbLzA0uuXftL7uoG6B +m8TW5tn3wDrq6AHFMWWfqY7edRb5y/6oEhul2eA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Quinn Tran , Nilesh Javali , Himanshu Madhani , "Martin K. Petersen" Subject: [PATCH 6.2 0961/1001] scsi: qla2xxx: Remove unintended flag clearing Date: Tue, 7 Mar 2023 18:02:13 +0100 Message-Id: <20230307170103.897488093@linuxfoundation.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230307170022.094103862@linuxfoundation.org> References: <20230307170022.094103862@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Quinn Tran commit 7e8a936a2d0f98dd6e5d05d4838affabe606cabc upstream. FCF_ASYNC_SENT flag is used in session management. This flag is cleared in task management path by accident. Remove unintended flag clearing. Fixes: 388a49959ee4 ("scsi: qla2xxx: Fix panic from use after free in qla2x00_async_tm_cmd") Cc: stable@vger.kernel.org Signed-off-by: Quinn Tran Signed-off-by: Nilesh Javali Reviewed-by: Himanshu Madhani Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_init.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -2076,7 +2076,6 @@ qla2x00_async_tm_cmd(fc_port_t *fcport, done_free_sp: /* ref: INIT */ kref_put(&sp->cmd_kref, qla2x00_sp_release); - fcport->flags &= ~FCF_ASYNC_SENT; done: return rval; }