From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D37D3C678D5 for ; Wed, 8 Mar 2023 01:06:25 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 280C1849E for ; Wed, 8 Mar 2023 01:06:25 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 192C69866E8 for ; Wed, 8 Mar 2023 01:06:25 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 10086984772; Wed, 8 Mar 2023 01:06:25 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id F18949866E4 for ; Wed, 8 Mar 2023 01:06:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: BVV4kxlkPbCTX4QqErISAw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678237579; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f/NOX4fXeGbT+btxfg/Qf0KHBrka3wo5x7t+sTIIWeY=; b=M80IYn9/HxVqC26+cEKLEgv2ESndJKczoNQ2Z8DguRXFuIXexma5Uz4EvzwA8jWbUE XV98d/r82EnRRx+asDtzjtUaOIV8YFXS80cGQiNAEhUVr8XqqG/BrIJ0QbFgioSx9hIn JPOoYZiiibuLkHqcK6LQopeJaLhgfSBrAZfuCmAHhrie4H2MSZjduwcIFye8/nLij5pG drisZdjejwY+FqlxFcOTedt+qWEVkWT+xWB8pzhYMln3pee5McGZU843WpC4BQ4zBYq3 L1BcbjIUaWIxglRbx0uQPaAldjf1l30Dy3oy+odqj3scpqD9PA0JAeh8sM4sCwmNL/xL PI5Q== X-Gm-Message-State: AO0yUKWaMJ3OGNmaj6i6A/pxVTsv27BC+nnoF1ImTvUo+2+OpwCiMhGb iVLATnQVmWeOteRqSbFz1zQsZxdqosgryLiQhqobxA+QxXR4BEWhPgUPLQHNX/3TDKGTfalvmqA 1nE8BYjeXtP+7PCv25lc1LGM2JYOIMylSJA== X-Received: by 2002:adf:e242:0:b0:2c5:4db8:3dde with SMTP id bl2-20020adfe242000000b002c54db83ddemr10156093wrb.70.1678237579059; Tue, 07 Mar 2023 17:06:19 -0800 (PST) X-Google-Smtp-Source: AK7set9aaqH/TcooYJSjXIYn0J4gmlCjhzm5NBHt+JeMjIzwHk2iG4QnNQtikyW+hzxEcDyP8QY9MQ== X-Received: by 2002:adf:e242:0:b0:2c5:4db8:3dde with SMTP id bl2-20020adfe242000000b002c54db83ddemr10156071wrb.70.1678237578758; Tue, 07 Mar 2023 17:06:18 -0800 (PST) Date: Tue, 7 Mar 2023 20:06:14 -0500 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Max Gurtovoy , Stefan Hajnoczi , "virtio-comment@lists.oasis-open.org" , "virtio-dev@lists.oasis-open.org" , "jasowang@redhat.com" , "cohuck@redhat.com" , "sgarzare@redhat.com" , "nrupal.jani@intel.com" , "Piotr.Uminski@intel.com" , "hang.yuan@intel.com" , "virtio@lists.oasis-open.org" , Zhu Lingshan , "pasic@linux.ibm.com" , Shahaf Shuler Message-ID: <20230307200307-mutt-send-email-mst@kernel.org> References: <910b3607a5f255134d30b3e1233e564f564eafb8.1677761896.git.mst@redhat.com> <20230302201912.GC2554028@fedora> <20230302185803-mutt-send-email-mst@kernel.org> <20230303131703.GB2866370@fedora> <20230303081900-mutt-send-email-mst@kernel.org> <4f869944-4ccd-c51e-0f30-dc3ba15ffd52@nvidia.com> <20230307192752-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-comment] Re: [PATCH v10 03/10] admin: introduce group administration commands On Wed, Mar 08, 2023 at 01:01:27AM +0000, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Tuesday, March 7, 2023 7:34 PM > > COMMAND_SPECIFIC_ERR is just way too much detail - commands generally > > just should not fail it's a quality of implementation issue. > > I disagree partially. > > 1. Hw device != sw_hypervisor device. > Device may fail or error out that may need want sw driver to retry. > Like Stefan's example, it may need to return timeout/retry intermittently. > Doesnt means the device is broken at that point. > > 2. A device implementation may not have imposed a certain locking scheme to synchronize VF enablement with VF provisioning. > ENODEV can reflect two commands not synchronized. > > So Boolean 0 = success, 22 = error is not the right way to craft the spec. > Many times, those sub-error codes are good indications of what may have gone wrong in the field. > Useful for the quality issue you pointed out to debug. Maybe, but I think we can just leave this stuff for later. Too much hand-waving, when we add commands that actually need this kind of ability that is when we will add the relevant error codes. -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7FDBC6FD1F for ; Wed, 8 Mar 2023 01:06:26 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 341A96008D for ; Wed, 8 Mar 2023 01:06:26 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 2B8699866ED for ; Wed, 8 Mar 2023 01:06:26 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 19A8C984772; Wed, 8 Mar 2023 01:06:26 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 056179866E1 for ; Wed, 8 Mar 2023 01:06:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: cFBnaQaPNYK6fhJwh22nvQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678237579; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f/NOX4fXeGbT+btxfg/Qf0KHBrka3wo5x7t+sTIIWeY=; b=H+vajR3gSQKp0EckB/FlEFI5X8GGoFRk92XDnNLgTqMENhXMl3ztlzf527WPVlDL4H D70ozdu47sOTOLpN+R9AlOdL5vuvWEBiq+DdZTecSaW8wFO3PLCBI2L+uL+6dR/j1/+f VTkrYgYoGbG8e6c7c0KTcEm7S6O5xKdrXw2cJ+GFmY7/w3RUogYYZUtgnC18tYbh77rI RYHDF2NHdEvxepYhPaGMfle/8PPcub/OygUCSA48uo0uHHFrE6jrxAYeByWROfTTbMGA 1YaK8Astad5fk1Psf9g1vL/nkIadX58/Cgif8GFA7iDhlTs40tWPbHhhF6UjNz6o7WpS lc3g== X-Gm-Message-State: AO0yUKWfQIboBtfJLenDoMfkvBKHdQEIaduFUoz4kMzq9R1dz1b+oSOB OybEkWJgOHSj45VSb+VnvKQmQh/lxLwJEjnALpyYXbvAW0j10VDn5JoeFx5LOhE7p9KEca/hqBP Cv5TFXGCMWlmYPsgA0Rg3TAZhYhr9 X-Received: by 2002:adf:e242:0:b0:2c5:4db8:3dde with SMTP id bl2-20020adfe242000000b002c54db83ddemr10156088wrb.70.1678237579059; Tue, 07 Mar 2023 17:06:19 -0800 (PST) X-Google-Smtp-Source: AK7set9aaqH/TcooYJSjXIYn0J4gmlCjhzm5NBHt+JeMjIzwHk2iG4QnNQtikyW+hzxEcDyP8QY9MQ== X-Received: by 2002:adf:e242:0:b0:2c5:4db8:3dde with SMTP id bl2-20020adfe242000000b002c54db83ddemr10156071wrb.70.1678237578758; Tue, 07 Mar 2023 17:06:18 -0800 (PST) Date: Tue, 7 Mar 2023 20:06:14 -0500 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Max Gurtovoy , Stefan Hajnoczi , "virtio-comment@lists.oasis-open.org" , "virtio-dev@lists.oasis-open.org" , "jasowang@redhat.com" , "cohuck@redhat.com" , "sgarzare@redhat.com" , "nrupal.jani@intel.com" , "Piotr.Uminski@intel.com" , "hang.yuan@intel.com" , "virtio@lists.oasis-open.org" , Zhu Lingshan , "pasic@linux.ibm.com" , Shahaf Shuler Message-ID: <20230307200307-mutt-send-email-mst@kernel.org> References: <910b3607a5f255134d30b3e1233e564f564eafb8.1677761896.git.mst@redhat.com> <20230302201912.GC2554028@fedora> <20230302185803-mutt-send-email-mst@kernel.org> <20230303131703.GB2866370@fedora> <20230303081900-mutt-send-email-mst@kernel.org> <4f869944-4ccd-c51e-0f30-dc3ba15ffd52@nvidia.com> <20230307192752-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [PATCH v10 03/10] admin: introduce group administration commands On Wed, Mar 08, 2023 at 01:01:27AM +0000, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Tuesday, March 7, 2023 7:34 PM > > COMMAND_SPECIFIC_ERR is just way too much detail - commands generally > > just should not fail it's a quality of implementation issue. > > I disagree partially. > > 1. Hw device != sw_hypervisor device. > Device may fail or error out that may need want sw driver to retry. > Like Stefan's example, it may need to return timeout/retry intermittently. > Doesnt means the device is broken at that point. > > 2. A device implementation may not have imposed a certain locking scheme to synchronize VF enablement with VF provisioning. > ENODEV can reflect two commands not synchronized. > > So Boolean 0 = success, 22 = error is not the right way to craft the spec. > Many times, those sub-error codes are good indications of what may have gone wrong in the field. > Useful for the quality issue you pointed out to debug. Maybe, but I think we can just leave this stuff for later. Too much hand-waving, when we add commands that actually need this kind of ability that is when we will add the relevant error codes. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org