All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: James Morse <james.morse@arm.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [morse:mpam/snapshot/v6.2 136/139] fs/debugfs/file.c:959:9: warning: no previous prototype for 'debugfs_read_file_cpumask'
Date: Tue, 7 Mar 2023 22:15:25 +0800	[thread overview]
Message-ID: <202303072202.jsd0sqAM-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/snapshot/v6.2
head:   b04a157f0da06d80607a04ca0c1f58b610ba4a44
commit: eca824efb549effb3884515952c8587ee46cc8fb [136/139] debugfs: Add helpers for creating cpumask entries in debugfs
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230307/202303072202.jsd0sqAM-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/commit/?id=eca824efb549effb3884515952c8587ee46cc8fb
        git remote add morse https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git
        git fetch --no-tags morse mpam/snapshot/v6.2
        git checkout eca824efb549effb3884515952c8587ee46cc8fb
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash fs/debugfs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303072202.jsd0sqAM-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/debugfs/file.c:959:9: warning: no previous prototype for 'debugfs_read_file_cpumask' [-Wmissing-prototypes]
     959 | ssize_t debugfs_read_file_cpumask(struct file *file, char __user *user_buf,
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +/debugfs_read_file_cpumask +959 fs/debugfs/file.c

   958	
 > 959	ssize_t debugfs_read_file_cpumask(struct file *file, char __user *user_buf,
   960					   size_t count, loff_t *ppos)
   961	{
   962		struct dentry *dentry = F_DENTRY(file);
   963		struct cpumask *cpumask;
   964		char *kernel_buf;
   965		ssize_t ret;
   966		int len;
   967	
   968		ret = debugfs_file_get(dentry);
   969		if (unlikely(ret))
   970			return ret;
   971	
   972		/* How long is a piece of string? */
   973		kernel_buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
   974		if (!kernel_buf) {
   975			debugfs_file_put(dentry);
   976			return -ENOMEM;
   977		}
   978	
   979		cpumask = (struct cpumask *)file->private_data;
   980		len = scnprintf(kernel_buf, PAGE_SIZE,
   981				"%*pb\n", cpumask_pr_args(cpumask));
   982		debugfs_file_put(dentry);
   983		if (len + 1 >= PAGE_SIZE) {
   984			kfree(kernel_buf);
   985			return -EIO;
   986		}
   987	
   988		ret = simple_read_from_buffer(user_buf, count, ppos, kernel_buf, len);
   989		kfree(kernel_buf);
   990	
   991		return ret;
   992	}
   993	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

                 reply	other threads:[~2023-03-07 14:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202303072202.jsd0sqAM-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=james.morse@arm.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.