From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] Rewrite ns_create using new LTP API
Date: Wed, 8 Mar 2023 09:42:36 +0100 [thread overview]
Message-ID: <20230308084236.GA16831@pevik> (raw)
In-Reply-To: <20230301091737.32083-1-andrea.cervesato@suse.com>
Hi Andrea,
> +/*\
> + * [Description]
nit: ns_create is a tool, not a test, therefore I would not add [Description]
(similarly e.g. nfs05_make_tree.c does not define it), but it's a detail, let's keep it.
> *
> - ***********************************************************************
> * Creates a child process in the new specified namespace(s), child is then
> * daemonized and is running in the background. PID of the daemonized child
> * process is printed on the stdout. As the new namespace(s) is(are) maintained
> * by the daemonized child process it(they) can be removed by killing this
> * process.
> - *
> */
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-03-08 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 9:17 [LTP] [PATCH v1] Rewrite ns_create using new LTP API Andrea Cervesato via ltp
2023-03-08 8:42 ` Petr Vorel [this message]
2023-03-09 9:01 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308084236.GA16831@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.