From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B56EBC76186 for ; Wed, 8 Mar 2023 14:12:32 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 048822B138 for ; Wed, 8 Mar 2023 14:12:32 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id F005E9866F4 for ; Wed, 8 Mar 2023 14:12:31 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id E89E69866EE; Wed, 8 Mar 2023 14:12:31 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id D59429866F0 for ; Wed, 8 Mar 2023 14:12:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: 3lBX0wy1NaSCLwkGn8iJ0Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678284747; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8pruHoaMxFEgALcLGx9ngc1OVBIItv+wn+Yja/fMhgI=; b=A+ru+np2is8ixIw/VwdW4/1uUlJ6Cx9HslSep3+4pLTWp/OoqPLyjVcWWeIIkm2nQD 5A9sm9kO1RB6NZQmh3iPb5vOp957O8nyh/J6xheVM82nr8wdelZjAqnKZQz0UyTH/kjR EWHsybaPtO3HTe8f6DECxcIJcVGYtU98qysEwJSG9Qrxq3uAkI/IOcvnsjf8VpOHJ7Tc 3+mU6LmW3dU0a8qUqcapxvvDztgkbplSe1Rgz9itR/LPeYmVhRAFN0bnVv7R4ltlJkoX cO1zhPq9E5hmm6CXNjcTqEXRKHYWo8EYCpDgm5Npsrb/5+/BrS0mpwD78RyYKQFD4IeM w8Bw== X-Gm-Message-State: AO0yUKWXX3/SAOY68efEVUbfSbjGwt5SbyrS50hFwHnXlST/wlaEae6T SmwF2ygDWjh0Vb+r7LTUn05PYfOljr1SKpO9QZB1nVrgVTnb2DLqbT6iDn7PcOqkmM3ON30HIIG kJAAoi2ngLoPheUpGNSiz6RpTkO/14PreCQ== X-Received: by 2002:a5d:5706:0:b0:2c7:b8a0:c42a with SMTP id a6-20020a5d5706000000b002c7b8a0c42amr10421834wrv.31.1678284746854; Wed, 08 Mar 2023 06:12:26 -0800 (PST) X-Google-Smtp-Source: AK7set9c0U9P3Im/6CdL1XjMiaqKZxxzqQrY6mFeodxNk97LC5u6vvgFrfrCXF8M1kv4D0OCCFjr6A== X-Received: by 2002:a5d:5706:0:b0:2c7:b8a0:c42a with SMTP id a6-20020a5d5706000000b002c7b8a0c42amr10421813wrv.31.1678284746512; Wed, 08 Mar 2023 06:12:26 -0800 (PST) Date: Wed, 8 Mar 2023 09:12:22 -0500 From: "Michael S. Tsirkin" To: Jiri Pirko Cc: David Edmondson , virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org, jasowang@redhat.com, cohuck@redhat.com, sgarzare@redhat.com, stefanha@redhat.com, nrupal.jani@intel.com, Piotr.Uminski@intel.com, hang.yuan@intel.com, virtio@lists.oasis-open.org, Zhu Lingshan , pasic@linux.ibm.com, Shahaf Shuler , Parav Pandit , Max Gurtovoy Message-ID: <20230308091103-mutt-send-email-mst@kernel.org> References: <6677477d48dfc234d3d1a339fb39d8fa2a3b983d.1677761896.git.mst@redhat.com> <20230308065526-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-comment] Re: [virtio] Re: [virtio-comment] [PATCH v10 09/10] admin: conformance clauses On Wed, Mar 08, 2023 at 03:02:05PM +0100, Jiri Pirko wrote: > Wed, Mar 08, 2023 at 02:44:08PM CET, david.edmondson@oracle.com wrote: > >Jiri Pirko writes: > > > >> Wed, Mar 08, 2023 at 01:59:10PM CET, david.edmondson@oracle.com wrote: > >>>"Michael S. Tsirkin" writes: > >>> > >>>> On Tue, Mar 07, 2023 at 11:04:33AM +0000, David Edmondson wrote: > >>>>> "Michael S. Tsirkin" writes: > >>>>> > +The driver MAY block use of VIRTIO_ADMIN_CMD_LIST_QUERY and > >>>>> > +VIRTIO_ADMIN_CMD_LIST_USE by issuing VIRTIO_ADMIN_CMD_LIST_USE > >>>>> > +with respective bits cleared in \field{command_specific_data}. > >>>>> > >>>>> This runs contrary to the assertion "The list of supported commands MUST > >>>>> NOT shrink", given that a driver is told to assume that > >>>>> VIRTIO_ADMIN_CMD_LIST_QUERY and VIRTIO_ADMIN_CMD_LIST_USE are the only > >>>>> commands initially available. > >>>> > >>>> Commands are still available just disabled, the meaning of > >>>> "MUST NOT shrink" is clarified by the following: > >>>> > >>>> > > +after reporting a given command as supported through > >>>> > > +VIRTIO_ADMIN_CMD_LIST_QUERY the device MUST NOT later report it > >>>> > > +as unsupported. > >>>> I will stick an "i.e." there to make it hopefully clearer. > >>> > >>>This puzzles me. > >>> > >>>I can see the point of blocking LIST_USE, but not of blocking > >> > >> What is that point, I'm curious. > > > >I might restrict the commands permitted by a device before handing it > >off to some subordinate less trusted code. > > Hmm, that is theoretical, or is there a usecase for that? > Maybe there will be a future version replacing VIRTIO_ADMIN_CMD_LIST_QUERY with a different command. Then we start with a device supporting both VIRTIO_ADMIN_CMD_LIST_QUERY and the new VIRTIO_ADMIN_FOO, and we block VIRTIO_ADMIN_CMD_LIST_QUERY for testing, to make sure driver is able to handle future devices without VIRTIO_ADMIN_CMD_LIST_QUERY. > > > >> > >>>LIST_QUERY. What's the purpose of this? > >> > >> I think that this might be just for the sake of treating all > >> commands equally. > >> > >> > >>>-- > >>>Time is waiting to explain, why refuse? > >>> > >>>--------------------------------------------------------------------- > >>>To unsubscribe from this mail list, you must leave the OASIS TC that > >>>generates this mail. Follow this link to all your TCs in OASIS at: > >>>https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php > >>> > >-- > >I used to get mad at my school, the teachers who taught me weren't cool. This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7E0FC7618B for ; Wed, 8 Mar 2023 14:12:34 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 399BF2A8F7 for ; Wed, 8 Mar 2023 14:12:34 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 2BDDA9866FC for ; Wed, 8 Mar 2023 14:12:34 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 1EB249866F1; Wed, 8 Mar 2023 14:12:34 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 0A8339866EF for ; Wed, 8 Mar 2023 14:12:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: qnOuLSK0PQy9V9KYtIhvEA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678284747; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8pruHoaMxFEgALcLGx9ngc1OVBIItv+wn+Yja/fMhgI=; b=BpLLm9Cjy9X9++bcVo8XX9czsFkwoX894IfdOjwWjw/xGkbXf4H8OHGrT0KYs/BdF7 SBTndNdpQeTH7EMmc3M5AqNDLgTfQwy6/3mDPEcQvj3Ijhh3VMD689SUdjM+PDRbLhra TM5GidZWCF4qgQKZWHRHOJNUnOipBrd5teqiTKManVBwLNNWGNsKxGQpGAtNX+33px/h UoZgwX+j/g+X8+Sa5KUTWNRJIB572g+MSzR94OXIwtVjEMVUMbhLNE3yMM3lR585FRs/ RC7widdck5pF1Pk4tfWH7k62nQQup8ZexwBIafFFfJgKoelHmrxnX61FGF+Ao8uWwIak gdbQ== X-Gm-Message-State: AO0yUKWgcY5sGeSQcrGeArwjdGtfZdErQ7XUM6NdAUffBz8m1+yT07zX mq3nC2aHZsIaQng7E2Pyw//ktrKovoYbU8hIgjCOBAyinN5ytpXu/311gHGkWaBB8qdVaRPQi/B 5lr2LyCrJhqC5PZBgJqfW4W03jFSK X-Received: by 2002:a5d:5706:0:b0:2c7:b8a0:c42a with SMTP id a6-20020a5d5706000000b002c7b8a0c42amr10421832wrv.31.1678284746854; Wed, 08 Mar 2023 06:12:26 -0800 (PST) X-Google-Smtp-Source: AK7set9c0U9P3Im/6CdL1XjMiaqKZxxzqQrY6mFeodxNk97LC5u6vvgFrfrCXF8M1kv4D0OCCFjr6A== X-Received: by 2002:a5d:5706:0:b0:2c7:b8a0:c42a with SMTP id a6-20020a5d5706000000b002c7b8a0c42amr10421813wrv.31.1678284746512; Wed, 08 Mar 2023 06:12:26 -0800 (PST) Date: Wed, 8 Mar 2023 09:12:22 -0500 From: "Michael S. Tsirkin" To: Jiri Pirko Cc: David Edmondson , virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org, jasowang@redhat.com, cohuck@redhat.com, sgarzare@redhat.com, stefanha@redhat.com, nrupal.jani@intel.com, Piotr.Uminski@intel.com, hang.yuan@intel.com, virtio@lists.oasis-open.org, Zhu Lingshan , pasic@linux.ibm.com, Shahaf Shuler , Parav Pandit , Max Gurtovoy Message-ID: <20230308091103-mutt-send-email-mst@kernel.org> References: <6677477d48dfc234d3d1a339fb39d8fa2a3b983d.1677761896.git.mst@redhat.com> <20230308065526-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [virtio] Re: [virtio-comment] [PATCH v10 09/10] admin: conformance clauses On Wed, Mar 08, 2023 at 03:02:05PM +0100, Jiri Pirko wrote: > Wed, Mar 08, 2023 at 02:44:08PM CET, david.edmondson@oracle.com wrote: > >Jiri Pirko writes: > > > >> Wed, Mar 08, 2023 at 01:59:10PM CET, david.edmondson@oracle.com wrote: > >>>"Michael S. Tsirkin" writes: > >>> > >>>> On Tue, Mar 07, 2023 at 11:04:33AM +0000, David Edmondson wrote: > >>>>> "Michael S. Tsirkin" writes: > >>>>> > +The driver MAY block use of VIRTIO_ADMIN_CMD_LIST_QUERY and > >>>>> > +VIRTIO_ADMIN_CMD_LIST_USE by issuing VIRTIO_ADMIN_CMD_LIST_USE > >>>>> > +with respective bits cleared in \field{command_specific_data}. > >>>>> > >>>>> This runs contrary to the assertion "The list of supported commands MUST > >>>>> NOT shrink", given that a driver is told to assume that > >>>>> VIRTIO_ADMIN_CMD_LIST_QUERY and VIRTIO_ADMIN_CMD_LIST_USE are the only > >>>>> commands initially available. > >>>> > >>>> Commands are still available just disabled, the meaning of > >>>> "MUST NOT shrink" is clarified by the following: > >>>> > >>>> > > +after reporting a given command as supported through > >>>> > > +VIRTIO_ADMIN_CMD_LIST_QUERY the device MUST NOT later report it > >>>> > > +as unsupported. > >>>> I will stick an "i.e." there to make it hopefully clearer. > >>> > >>>This puzzles me. > >>> > >>>I can see the point of blocking LIST_USE, but not of blocking > >> > >> What is that point, I'm curious. > > > >I might restrict the commands permitted by a device before handing it > >off to some subordinate less trusted code. > > Hmm, that is theoretical, or is there a usecase for that? > Maybe there will be a future version replacing VIRTIO_ADMIN_CMD_LIST_QUERY with a different command. Then we start with a device supporting both VIRTIO_ADMIN_CMD_LIST_QUERY and the new VIRTIO_ADMIN_FOO, and we block VIRTIO_ADMIN_CMD_LIST_QUERY for testing, to make sure driver is able to handle future devices without VIRTIO_ADMIN_CMD_LIST_QUERY. > > > >> > >>>LIST_QUERY. What's the purpose of this? > >> > >> I think that this might be just for the sake of treating all > >> commands equally. > >> > >> > >>>-- > >>>Time is waiting to explain, why refuse? > >>> > >>>--------------------------------------------------------------------- > >>>To unsubscribe from this mail list, you must leave the OASIS TC that > >>>generates this mail. Follow this link to all your TCs in OASIS at: > >>>https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php > >>> > >-- > >I used to get mad at my school, the teachers who taught me weren't cool. --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org