From: Eric Wong <e@80x24.org>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Fabian Stelzer" <fs@gigacodes.de>,
"Brandon Casey" <drafnel@gmail.com>
Subject: Re: [PATCH] test: simplify counts aggregation
Date: Wed, 8 Mar 2023 09:26:21 +0000 [thread overview]
Message-ID: <20230308092621.M321240@dcvr> (raw)
In-Reply-To: <230308.86bkl3zjp3.gmgdl@evledraar.gmail.com>
> On Wed, Mar 08 2023, Felipe Contreras wrote:
> > +++ b/t/Makefile
> > + '$(SHELL_PATH_SQ)' ./aggregate-results.sh '$(TEST_RESULTS_DIRECTORY_SQ)/t*-*.counts'
> > +++ b/t/aggregate-results.sh
> >
> > -while read file
> > +for file in $1
Reading aggregate-results.sh alone looks wrong; but your patch is
correct overall because of how it's invoked from the Makefile.
I think that's too subtle...
Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> I think we can go even further here, and just pass the
> $(TEST_RESULTS_DIRECTORY_SQ) as an argument to the script
Yes.
next prev parent reply other threads:[~2023-03-08 9:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 9:05 [PATCH] test: simplify counts aggregation Felipe Contreras
2023-03-08 9:12 ` Ævar Arnfjörð Bjarmason
2023-03-08 9:26 ` Eric Wong [this message]
2023-03-08 10:04 ` Felipe Contreras
2023-03-08 9:56 ` Felipe Contreras
2023-03-08 11:15 ` Ævar Arnfjörð Bjarmason
2023-03-08 12:07 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308092621.M321240@dcvr \
--to=e@80x24.org \
--cc=avarab@gmail.com \
--cc=drafnel@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.