From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CC00C678D5 for ; Wed, 8 Mar 2023 16:30:37 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id D376C33581 for ; Wed, 8 Mar 2023 16:30:36 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id C711898670B for ; Wed, 8 Mar 2023 16:30:36 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id BF2449866F1; Wed, 8 Mar 2023 16:30:36 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 9781B986704 for ; Wed, 8 Mar 2023 16:30:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: mml6lP5IPwS5xkUHHT8Z9Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678293026; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DDsU3IQnVwpATYkXoKJ8Qw0OvII2PbE5ToGOeKuDk6Y=; b=XFPWHSVDY/5ShYWLGQ/9ZVownz5MSY1XMYgaR8jtbVQujHdqrVJAcX8PxVy1UKdvCv RP2YHjeFp4Br82HAIJXBT3betJ2PPlL/v8jyZZxmFjD8kgZPAtAxWQa2OSffZpxaOcHu +LweYidF5gY1I2JSUAFZpO871xDb2iqTlYTtC21nPFjKBWw0QE/N5cazK8h7pAso+neF YRLp4vYrtM7xMnp5imrsev+Wmc8F6DCSIvbgs9Z/5P37mwxkLvyi9pipCLJXmCrxLh7o GCe3TYJgSiPrQ9hXAXMFiYuqqFOGmJjbsyDwI1o+lFSY8Dv/4pOMZIPh6Czr4sdC17Si Ri/w== X-Gm-Message-State: AO0yUKVYIkEVrXO8DIktq0wsW1W3YCu0SvnjiNaWsb9ekAtJ7mRQomB/ 0sClrbKAFqJmefOpUKPZ89EOhjZR9CjI4GVTugpch2ynB+njsNyxCpK1FRt0cY5TkKTRo2JiIz+ B6GT5U6lOqc+wmcfPOhxRPDp/aOCZDjurKg== X-Received: by 2002:a17:907:80e:b0:8b0:f58d:2da9 with SMTP id wv14-20020a170907080e00b008b0f58d2da9mr24360746ejb.64.1678293026628; Wed, 08 Mar 2023 08:30:26 -0800 (PST) X-Google-Smtp-Source: AK7set9gufTkbEaEF/UQXAcBV2+nY0tEhyxHBA2K2oEpaX4DmaHHxyajwK9X1zHpvi4GJvZV7DDysg== X-Received: by 2002:a17:907:80e:b0:8b0:f58d:2da9 with SMTP id wv14-20020a170907080e00b008b0f58d2da9mr24360710ejb.64.1678293026380; Wed, 08 Mar 2023 08:30:26 -0800 (PST) Date: Wed, 8 Mar 2023 11:30:21 -0500 From: "Michael S. Tsirkin" To: Parav Pandit Cc: "virtio-comment@lists.oasis-open.org" , "virtio-dev@lists.oasis-open.org" , "jasowang@redhat.com" , "cohuck@redhat.com" , "sgarzare@redhat.com" , "stefanha@redhat.com" , "nrupal.jani@intel.com" , "Piotr.Uminski@intel.com" , "hang.yuan@intel.com" , "virtio@lists.oasis-open.org" , Zhu Lingshan , "pasic@linux.ibm.com" , Shahaf Shuler , Max Gurtovoy Message-ID: <20230308112854-mutt-send-email-mst@kernel.org> References: <20230303032434-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-comment] Re: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved On Tue, Mar 07, 2023 at 06:52:03PM +0000, Parav Pandit wrote: > > And I wonder whether it's worth it - it definitely makes contributing to Linux > > harder, and even within Linux it pushes contributors away. > The number of virtio spec contributors are in order of magnitude less > than Linux kernel or just the Linux netdev. Patch split up reduces > lot of time author and reviewers. For example, interrupt moderation > at v10 can be very easily split up where prep patch can have RB tag > and v11 doesn't need reviewers and author's time. Your work here with > 10 patches is yet another good example of it. I remember Max and I > started with 6 patches... and current 10 are more useful way to split > them. It's a big project though. All I ask is that we try to be gentler than netdev to new contributors. If there's a 10 line patch it is not necessary to be pedantic and ask for it to be split up to a 3 patch series. -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D7FEC64EC4 for ; Wed, 8 Mar 2023 16:30:31 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id E64392AEDF for ; Wed, 8 Mar 2023 16:30:30 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id C1F939866FC for ; Wed, 8 Mar 2023 16:30:30 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id A85119866F0; Wed, 8 Mar 2023 16:30:30 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 956929866F2 for ; Wed, 8 Mar 2023 16:30:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: X9p4qpjbPIORNhQaEVTLZQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678293026; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DDsU3IQnVwpATYkXoKJ8Qw0OvII2PbE5ToGOeKuDk6Y=; b=UDgRwqlFSJmQIzTtVHnjzR4pENxecK6j8ETT4icgiWLHIyqjLegEtDrtHPjOom+OnI 0mWxZb4/JzlDJqiroUjOIqUAuiDthsIaFJzkYlgfbhgkjc9VY9eSS/w+wLsXE95nnbwF wZauwphVpLZbxicrlMcEPRAVPbcmEkp8w13BKM/tk3nNLC+zpotDfU+IGHoPdogOg1RG PSCbl1GKc4WYmudHlb8EX+XaAXgh/XN150m/YfT3frDnZojoI5rivGyYxIOHszqbHYNn lzDpq5y65yCufKIQ16JXxxD/pdcpBFVmgwCpFpx4Sa7iKYrZkeK6qc26nSt9DlB1VO2z PKTw== X-Gm-Message-State: AO0yUKU5G/lZdfNMShsV4SumsNe29Bg0qCzT7kp0tSgX2+wm5eSNOCYN 6vvPJIfZt3rL3PcmOzkdLrYmaNW5gWTTP6ZR3YTrNbIbC40BBC7rFE0smUwIJIXaCzzwuVF+PVX OarJ24TXDQBjj9GPH2cz54LCNOdMq X-Received: by 2002:a17:907:80e:b0:8b0:f58d:2da9 with SMTP id wv14-20020a170907080e00b008b0f58d2da9mr24360741ejb.64.1678293026626; Wed, 08 Mar 2023 08:30:26 -0800 (PST) X-Google-Smtp-Source: AK7set9gufTkbEaEF/UQXAcBV2+nY0tEhyxHBA2K2oEpaX4DmaHHxyajwK9X1zHpvi4GJvZV7DDysg== X-Received: by 2002:a17:907:80e:b0:8b0:f58d:2da9 with SMTP id wv14-20020a170907080e00b008b0f58d2da9mr24360710ejb.64.1678293026380; Wed, 08 Mar 2023 08:30:26 -0800 (PST) Date: Wed, 8 Mar 2023 11:30:21 -0500 From: "Michael S. Tsirkin" To: Parav Pandit Cc: "virtio-comment@lists.oasis-open.org" , "virtio-dev@lists.oasis-open.org" , "jasowang@redhat.com" , "cohuck@redhat.com" , "sgarzare@redhat.com" , "stefanha@redhat.com" , "nrupal.jani@intel.com" , "Piotr.Uminski@intel.com" , "hang.yuan@intel.com" , "virtio@lists.oasis-open.org" , Zhu Lingshan , "pasic@linux.ibm.com" , Shahaf Shuler , Max Gurtovoy Message-ID: <20230308112854-mutt-send-email-mst@kernel.org> References: <20230303032434-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved On Tue, Mar 07, 2023 at 06:52:03PM +0000, Parav Pandit wrote: > > And I wonder whether it's worth it - it definitely makes contributing to Linux > > harder, and even within Linux it pushes contributors away. > The number of virtio spec contributors are in order of magnitude less > than Linux kernel or just the Linux netdev. Patch split up reduces > lot of time author and reviewers. For example, interrupt moderation > at v10 can be very easily split up where prep patch can have RB tag > and v11 doesn't need reviewers and author's time. Your work here with > 10 patches is yet another good example of it. I remember Max and I > started with 6 patches... and current 10 are more useful way to split > them. It's a big project though. All I ask is that we try to be gentler than netdev to new contributors. If there's a 10 line patch it is not necessary to be pedantic and ask for it to be split up to a 3 patch series. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org