From: Lee Jones <lee@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Jonathan Corbet <corbet@lwn.net>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
John Crispin <john@phrozen.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, Tim Harvey <tharvey@gateworks.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Arun.Ramadoss@microchip.com
Subject: Re: [PATCH v8 00/13] Adds support for PHY LEDs with offload triggers
Date: Wed, 8 Mar 2023 14:06:42 +0000 [thread overview]
Message-ID: <20230308140642.GO9667@google.com> (raw)
In-Reply-To: <6406344a.050a0220.693b3.6689@mx.google.com>
On Mon, 06 Mar 2023, Christian Marangi wrote:
> On Wed, Feb 22, 2023 at 03:02:04PM +0000, Lee Jones wrote:
> > On Fri, 17 Feb 2023, Andrew Lunn wrote:
> >
> > > On Thu, Feb 16, 2023 at 02:32:17AM +0100, Christian Marangi wrote:
> > > > This is another attempt on adding this feature on LEDs, hoping this is
> > > > the right time and someone finally notice this.
> > >
> > > Hi Christian
> > >
> > > Thanks for keeping working on this.
> > >
> > > I want to review it, and maybe implement LED support in a PHY
> > > driver. But i'm busy with reworking EEE at the moment.
> > >
> > > The merge window is about to open, so patches are not going to be
> > > accepted for the next two weeks. So i will take a look within that
> > > time and give you feedback.
> >
> > Thanks Andrew. If Pavel is still unavailable to conduct reviews, I'm
> > going to need all the help I can get with complex submissions such as
> > these.
> >
>
> Hi Lee,
> thanks for stepping in. Just wanted to tell you I got some message with
> Andrew to make this thing less problematic and to dry/make it more
> review friendly.
>
> We decided on pushing this in 3 step:
> 1. Propose most basic things for some switch and some PHY. (brightness
> and blink_set support only, already supported by LED core)
> 2. A small series that should be just a cleanup for the netdev trigger
> 3. Support for hw_control in the most possible clean and way with small
> patch to they are not hard to track and understand the concept of this
> feature.
>
> I'm starting with the step 1 and sending some of my patch and Andrew
> patch to add basic support and I will add you and LED mailing list in
> Cc.
Sounds like a plan. Thank you both.
> Again thanks for starting checking this and feel free to ask any
> question about this to me also privately, I'm very open to any help.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-03-08 14:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 1:32 [PATCH v8 00/13] Adds support for PHY LEDs with offload triggers Christian Marangi
2023-02-16 1:32 ` [PATCH v8 01/13] leds: add support for hardware driven LEDs Christian Marangi
2023-02-16 1:32 ` [PATCH v8 02/13] leds: add function to configure hardware controlled LED Christian Marangi
2023-02-16 1:32 ` [PATCH v8 03/13] leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from mode Christian Marangi
2023-02-16 1:32 ` [PATCH v8 04/13] leds: trigger: netdev: rename and expose NETDEV trigger enum modes Christian Marangi
2023-02-16 1:32 ` [PATCH v8 05/13] leds: trigger: netdev: convert device attr to macro Christian Marangi
2023-02-16 1:32 ` [PATCH v8 06/13] leds: trigger: netdev: add hardware control support Christian Marangi
2023-02-16 1:32 ` [PATCH v8 07/13] leds: trigger: netdev: use mutex instead of spinlocks Christian Marangi
2023-02-16 1:32 ` [PATCH v8 08/13] leds: trigger: netdev: add available mode sysfs attr Christian Marangi
2023-02-16 1:32 ` [PATCH v8 09/13] leds: trigger: netdev: add additional hardware only triggers Christian Marangi
2023-02-16 1:32 ` [PATCH v8 10/13] net: dsa: qca8k: add LEDs support Christian Marangi
2023-02-16 1:32 ` [PATCH v8 11/13] dt-bindings: leds: Document netdev trigger Christian Marangi
2023-02-17 23:03 ` Rob Herring
2023-02-17 5:58 ` Christian Marangi
2023-02-21 1:44 ` Rob Herring
2023-02-16 1:32 ` [PATCH v8 12/13] dt-bindings: net: phy: Document support for leds node Christian Marangi
2023-02-16 2:32 ` Rob Herring
2023-02-16 10:00 ` Christian Marangi
2023-02-17 23:10 ` Rob Herring
2023-02-16 1:32 ` [PATCH v8 13/13] dt-bindings: net: dsa: qca8k: add LEDs definition example Christian Marangi
2023-02-21 1:48 ` Rob Herring
2023-02-17 14:30 ` [PATCH v8 00/13] Adds support for PHY LEDs with offload triggers Andrew Lunn
2023-02-17 5:01 ` Christian Marangi
2023-02-22 15:02 ` Lee Jones
2023-03-06 18:43 ` Christian Marangi
2023-03-08 14:06 ` Lee Jones [this message]
2023-03-09 9:09 ` Linus Walleij
2023-03-09 9:32 ` Hans de Goede
2023-03-09 15:22 ` Andrew Lunn
2023-03-10 9:37 ` Linus Walleij
2023-03-10 15:15 ` Andrew Lunn
2023-03-13 9:28 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308140642.GO9667@google.com \
--to=lee@kernel.org \
--cc=Arun.Ramadoss@microchip.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=john@phrozen.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
--cc=rasmus.villemoes@prevas.dk \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.