From: Christoph Hellwig <hch@lst.de>
To: Danilo Krummrich <dakr@redhat.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
"Liam R. Howlett" <Liam.Howlett@Oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
maple-tree@lists.infradead.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] maple_tree: export symbol mas_preallocate()
Date: Wed, 8 Mar 2023 15:43:43 +0100 [thread overview]
Message-ID: <20230308144343.GA16259@lst.de> (raw)
In-Reply-To: <da65d59e-f918-d7d5-644b-33cc51c2ba6c@redhat.com>
On Wed, Mar 08, 2023 at 03:34:29PM +0100, Danilo Krummrich wrote:
> On 3/8/23 11:59, Vlastimil Babka wrote:
>> On 3/2/23 02:52, Liam R. Howlett wrote:
>>> Thanks for the patch. This should indeed be exported.
>>>
>>> Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
>>
>> What uses it? Don't we export only things used by in-kernel modules?
>
> mas_preallocate() is part of the maple tree's 'Advanced API'. All other
> functions of this API are exported already.
>
> More specifically, e.g. mas_store_prealloc() is exported which doesn't make
> a lot of sense without mas_preallocate() being available too.
>
> I don't think it is used outside of mm yet, but as a generic tree
> implementation maple tree is pretty likely to be used in code built as
> module, e.g. drivers.
If anyone wants to use they can add the export as needed.
next prev parent reply other threads:[~2023-03-08 14:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 1:10 [PATCH] maple_tree: export symbol mas_preallocate() Danilo Krummrich
2023-03-02 1:52 ` Liam R. Howlett
2023-03-08 10:59 ` Vlastimil Babka
2023-03-08 14:34 ` Danilo Krummrich
2023-03-08 14:43 ` Christoph Hellwig [this message]
2023-03-08 15:18 ` Danilo Krummrich
2023-03-08 15:29 ` Christoph Hellwig
2023-03-08 17:43 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308144343.GA16259@lst.de \
--to=hch@lst.de \
--cc=Liam.Howlett@Oracle.com \
--cc=dakr@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.