From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A670EC678D5 for ; Wed, 8 Mar 2023 20:15:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230247AbjCHUPQ (ORCPT ); Wed, 8 Mar 2023 15:15:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230296AbjCHUOw (ORCPT ); Wed, 8 Mar 2023 15:14:52 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B819BD38E3 for ; Wed, 8 Mar 2023 12:14:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5DC0DB81DFD for ; Wed, 8 Mar 2023 20:14:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F419CC433EF; Wed, 8 Mar 2023 20:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1678306472; bh=gAscky9bIridxwJnuNKQoYfCVd1n2KUiHcEHrCJ/G54=; h=Date:To:From:Subject:From; b=mpzCBxHEqcv25/i9oPMYXZ3PlhcZnDvchRcSvRldhEbvN3+ssgIZsQXK9KY9LlFyA mFsCQdtIf0AM+dfG7wAQ0/9VRKAttR+eodPhmvdO5YwXJml1rBB4in0KbRQSYUidWy wfXH8CDwtKgKFBSl+TFoujFlYP0fRdU6iGaufhUM= Date: Wed, 08 Mar 2023 12:14:31 -0800 To: mm-commits@vger.kernel.org, willy@infradead.org, tangyeechou@gmail.com, shakeelb@google.com, roman.gushchin@linux.dev, muchun.song@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, findns94@gmail.com, akpm@linux-foundation.org From: Andrew Morton Subject: + mm-memcg-prevent-memorysoft_limit_in_bytes-load-store-tearing-v3.patch added to mm-unstable branch Message-Id: <20230308201431.F419CC433EF@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: mm-memcg-prevent-memorysoft_limit_in_bytes-load-store-tearing-v3 has been added to the -mm mm-unstable branch. Its filename is mm-memcg-prevent-memorysoft_limit_in_bytes-load-store-tearing-v3.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-memcg-prevent-memorysoft_limit_in_bytes-load-store-tearing-v3.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Yue Zhao Subject: mm-memcg-prevent-memorysoft_limit_in_bytes-load-store-tearing-v3 Date: Thu, 9 Mar 2023 00:25:55 +0800 Add [WRITE|READ]_ONCE for all occurrences of memcg->oom_kill_disable, memcg->swappiness and memcg->soft_limit. Link: https://lkml.kernel.org/r/20230308162555.14195-5-findns94@gmail.com Signed-off-by: Yue Zhao Cc: Johannes Weiner Cc: Matthew Wilcox (Oracle) Cc: Michal Hocko Cc: Muchun Song Cc: Roman Gushchin Cc: Shakeel Butt Cc: Tang Yizhou Signed-off-by: Andrew Morton --- --- a/mm/memcontrol.c~mm-memcg-prevent-memorysoft_limit_in_bytes-load-store-tearing-v3 +++ a/mm/memcontrol.c @@ -5347,7 +5347,7 @@ mem_cgroup_css_alloc(struct cgroup_subsy return ERR_CAST(memcg); page_counter_set_high(&memcg->memory, PAGE_COUNTER_MAX); - memcg->soft_limit = PAGE_COUNTER_MAX; + WRITE_ONCE(memcg->soft_limit, PAGE_COUNTER_MAX); #if defined(CONFIG_MEMCG_KMEM) && defined(CONFIG_ZSWAP) memcg->zswap_max = PAGE_COUNTER_MAX; #endif @@ -5502,7 +5502,7 @@ static void mem_cgroup_css_reset(struct page_counter_set_min(&memcg->memory, 0); page_counter_set_low(&memcg->memory, 0); page_counter_set_high(&memcg->memory, PAGE_COUNTER_MAX); - memcg->soft_limit = PAGE_COUNTER_MAX; + WRITE_ONCE(memcg->soft_limit, PAGE_COUNTER_MAX); page_counter_set_high(&memcg->swap, PAGE_COUNTER_MAX); memcg_wb_domain_size_changed(memcg); } _ Patches currently in -mm which might be from findns94@gmail.com are mm-memcg-prevent-memoryoomgroup-load-store-tearing.patch mm-memcg-prevent-memoryswappiness-load-store-tearing.patch mm-memcg-prevent-memoryswappiness-load-store-tearing-v3.patch mm-memcg-prevent-memoryoom_control-load-store-tearing.patch mm-memcg-prevent-memoryoom_control-load-store-tearing-v3.patch mm-memcg-prevent-memorysoft_limit_in_bytes-load-store-tearing.patch mm-memcg-prevent-memorysoft_limit_in_bytes-load-store-tearing-v3.patch