From: Jakub Kicinski <kuba@kernel.org>
To: Kristian Overskeid <koverskeid@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: hsr: Don't log netdev_err message on unknown prp dst node
Date: Wed, 8 Mar 2023 23:20:01 -0800 [thread overview]
Message-ID: <20230308232001.2fb62013@kernel.org> (raw)
In-Reply-To: <20230307133229.127442-1-koverskeid@gmail.com>
On Tue, 7 Mar 2023 14:32:29 +0100 Kristian Overskeid wrote:
> if (!node_dst) {
> - if (net_ratelimit())
> + if (net_ratelimit() && port->hsr->prot_version != PRP_V1)
nit: wouldn't the condition make more sense before the net_ratelimit() ?
net_ratelimit() will update its state which is unnecessary if we're not
going to print either way.
When you repost - could you cast a wider net with the CC list?
Add the author of the code? (The print itself, not Taehee)
Maybe some folks who touched this file most recently?
> netdev_err(skb->dev, "%s: Unknown node\n", __func__);
prev parent reply other threads:[~2023-03-09 7:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 13:32 [PATCH] net: hsr: Don't log netdev_err message on unknown prp dst node Kristian Overskeid
2023-03-09 7:20 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308232001.2fb62013@kernel.org \
--to=kuba@kernel.org \
--cc=koverskeid@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.