From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jiri Pirko <jiri@nvidia.com>
Cc: virtualization@lists.linux-foundation.org,
Bodong Wang <bodong@nvidia.com>, Gavin Li <gavinl@nvidia.com>
Subject: Re: [PATCH 3/3] virtio_ring: Use const to annotate read-only pointer params
Date: Thu, 9 Mar 2023 09:27:33 -0500 [thread overview]
Message-ID: <20230309092451-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <ZAmlwyVfz+IK1b6T@nanopsycho>
On Thu, Mar 09, 2023 at 10:24:19AM +0100, Jiri Pirko wrote:
> >Nice but the bigger problem is not the mistake - it is the posting of
> >untested code. It might be an ok thing to do - as long as you make it
> >super abundantrly clear that this is what it is, and explain why
> >you are posting it now and not after testing.
>
> Isn't there some ci running with posted patches here? That would uncover
> it right away. In netdev world, this is very convenient. Example:
> https://patchwork.kernel.org/project/netdevbpf/list/?series=727865
> Patch won't apply.
It is a best effort thing and is not an excuse to post untested patches
for review. If I see a patch I expect that the author made sure
the patch does what it's supposed to do.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-03-09 14:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 3:57 [PATCH 0/3] virtio_ring: Clean up code for virtio ring and pci Feng Liu via Virtualization
2023-03-07 3:57 ` [PATCH 1/3] virtio_pci_modern: Remove unnecessary num zero check Feng Liu via Virtualization
2023-03-07 9:10 ` David Edmondson
2023-03-08 5:52 ` Jason Wang
2023-03-08 6:57 ` Michael S. Tsirkin
2023-03-08 14:23 ` Michael S. Tsirkin
2023-03-08 14:33 ` Feng Liu via Virtualization
2023-03-07 3:57 ` [PATCH 2/3] virtio_ring: Avoid using inline for small functions Feng Liu via Virtualization
2023-03-07 9:11 ` David Edmondson
2023-03-08 5:55 ` Jason Wang
2023-03-07 3:57 ` [PATCH 3/3] virtio_ring: Use const to annotate read-only pointer params Feng Liu via Virtualization
2023-03-07 9:14 ` David Edmondson
2023-03-07 21:17 ` Feng Liu via Virtualization
2023-03-08 14:13 ` Michael S. Tsirkin
2023-03-08 15:59 ` Feng Liu via Virtualization
2023-03-08 16:25 ` Michael S. Tsirkin
2023-03-08 16:44 ` Feng Liu via Virtualization
2023-03-08 16:49 ` Michael S. Tsirkin
2023-03-08 17:26 ` Feng Liu via Virtualization
2023-03-08 5:58 ` Jason Wang
2023-03-08 14:07 ` Feng Liu via Virtualization
2023-03-08 14:13 ` Feng Liu via Virtualization
2023-03-08 14:16 ` Michael S. Tsirkin
2023-03-08 14:19 ` Feng Liu via Virtualization
2023-03-08 14:28 ` Michael S. Tsirkin
2023-03-08 14:40 ` Feng Liu via Virtualization
2023-03-08 14:47 ` Michael S. Tsirkin
2023-03-08 15:47 ` Feng Liu via Virtualization
[not found] ` <ZAmlwyVfz+IK1b6T@nanopsycho>
2023-03-09 14:27 ` Michael S. Tsirkin [this message]
2023-03-08 6:59 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309092451-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=bodong@nvidia.com \
--cc=gavinl@nvidia.com \
--cc=jiri@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.